Skip to content

[wasm] WasmDebugLevel in samples #79644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2022
Merged

[wasm] WasmDebugLevel in samples #79644

merged 2 commits into from
Dec 15, 2022

Conversation

@pavelsavara
Copy link
Member

do not enable debugging is samples in release mode because it disables interp optimizations

See

runtime/src/mono/wasm/runtime/driver.c

Lines 567 to 571 in 8e15d9f

if (debug_level) {
// Disable optimizations which interfere with debugging
interp_opts = "-all";
mono_wasm_enable_debugging (debug_level);
}

@pavelsavara pavelsavara added this to the 8.0.0 milestone Dec 14, 2022
@pavelsavara pavelsavara requested a review from lewing as a code owner December 14, 2022 12:47
@pavelsavara pavelsavara self-assigned this Dec 14, 2022
@ghost
Copy link

ghost commented Dec 14, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

do not enable debugging is samples in release mode because it disables interp optimizations

See

runtime/src/mono/wasm/runtime/driver.c

Lines 567 to 571 in 8e15d9f

if (debug_level) {
// Disable optimizations which interfere with debugging
interp_opts = "-all";
mono_wasm_enable_debugging (debug_level);
}

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@radical
Copy link
Member

radical commented Dec 14, 2022

Add a xml comment too, so this doesn't get removed by accident.

@pavelsavara pavelsavara requested a review from thaystg December 14, 2022 15:14
@build-analysis build-analysis bot mentioned this pull request Dec 14, 2022
Closed
@pavelsavara
Copy link
Member Author

Failure is unrelated

@pavelsavara pavelsavara merged commit e395c7c into dotnet:main Dec 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2023
@pavelsavara pavelsavara deleted the wasm_not_debugging_release_samples branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

@radekdoulik radekdoulik radekdoulik approved these changes

@thaystg thaystg thaystg approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@BrzVlad BrzVlad Awaiting requested review from BrzVlad

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@pavelsavara @radical @radekdoulik @thaystg @ilonatommy