-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Proof of concept port of interleave feature #78374
Conversation
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsPR so that hopefully somebody can apply this fix: PR is code from Kevin: Main threads:
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsPR so that hopefully somebody can apply this fix: PR is code from Kevin: Main threads:
|
@krwq @carlossanlop Could you both weigh in on this? Do you agree that we should add this support? Do you have any concerns about this moving forward? @wstaelens for the time-being, I'm going to mark this as a Draft. The title implies it's a work-in-progress; is that true, or would this be ready for review if we agree in spirit that this can move forward? Thanks! |
@jeffhandley first of all: THANK YOU for looking at this after all these years. The situation:
@KevinCathcart did in his PR a port already of the .NET Framework code. To be honest, I'm not that familiar with the .net sources itself to be able to fix this issue myself. So to answer the question, I don't know how much is missing from Kevin/this PR. Original PR info: #51929 (comment) In case there is a new version or a dll we should test, let me know. |
My personal opinion is that does seem like important scenario to support. We should ensure testing and quality and this should go through regular feature development process. Ultimately it's up to area owner to decide. IMO we should especially focus on adding tests which use this piece of code same way (or as close as can be predicted) it's going to be used by XPS code. Most likely there should be PRs open on both repos and the XPS code should be tested with private bits from this PR. |
I'm going to go ahead and close this. Per @krwq's comments, before we'd be able to bring in new functionality in this space, we have work to do to get the test coverage up to a better position. We know that XPS related scenarios are causing folks frustration though. Thanks for submitting this @wstaelens, nonetheless. |
@jeffhandley so this is a polite messsage telling me you closed this and it will not be fixed? @krwq ? |
@wstaelens It's not that it won't be fixed, but that we are going to need to plan for adequate time for investments into the test coverage and other planning before we can move product/code changes forward. While that effort isn't currently planned, we recognize that XPS related scenarios have been frustrating for many and we will consider this space as one needing investment. I don't expect we'll be able to make such investments during the .NET 8 release cycle though. |
code of .NET Framework works fine. We were "forced" to move to .net (core). The only problem is that this part of code isn't fully ported and functionality doesn't work anymore compared to .NET Framework. Microsoft's own default drivers produce interleaved piece XPS print jobs but they can't be read anymore. After ± 7 - 8 years it is again being labeled as "Future". 😞
Wonder what the excuse of .net 9 will be 😢 |
PR so that hopefully somebody can apply this fix:
PR is code from Kevin:
#51929 (comment)
Main threads:
dotnet/wpf#3546
and
#51929