Skip to content

Conversation

@davidwrighton
Copy link
Member

  • Crossgen2 compiler was failing to detect that structs containing Int128 needed marshalling
  • The contract we provide is that Int128 is aligned within a structure, but we do not provide guarantees around 128bit alignment itself, so the test needed updating for that.

Fixes #74318

@davidwrighton davidwrighton merged commit bd4bea6 into dotnet:main Aug 23, 2022
@akoeplinger
Copy link
Member

@davidwrighton I've seen this failing in 7.0-rc1 too, do you plan on backporting the fix?

@davidwrighton
Copy link
Member Author

@akoeplinger I plan to fix this in 7.0, but not port to 7.0-rc1 unless there is some specific ask to do so.

@davidwrighton
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

@akoeplinger
Copy link
Member

That's fine by me, I just saw it failing in 7.0-rc1 as part of Test Monitor.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2022
@davidwrighton davidwrighton deleted the fix_74318 branch April 13, 2023 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure Interop/PInvoke/Int128/Int128TestFieldLayout/Int128TestFieldLayout.sh

5 participants