Skip to content

Add dotnet8 feeds in main nuget.config #74101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 18, 2022
Merged

Add dotnet8 feeds in main nuget.config #74101

merged 3 commits into from
Aug 18, 2022

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Aug 17, 2022 •
edited by ViktorHofer
Loading

Contributes to #63375
Contributes to #72112

@carlossanlop carlossanlop self-assigned this Aug 17, 2022
@ghost
Copy link

ghost commented Aug 17, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #63375
Addresses #72112

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure
Milestone: -

@carlossanlop carlossanlop mentioned this pull request Aug 17, 2022
Closed
7 tasks
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Aug 17, 2022

This PR is fixing the following item from #72112:

Add the dotnet8 feeds to the NuGet.config

But I think I have to bring back the dotnet7 feeds because of the next item:

At a later point when all dependencies are available in the .NET 8 feeds, remove the .NET 7 feeds.

ViktorHofer
ViktorHofer reviewed Aug 17, 2022
View reviewed changes
ViktorHofer
ViktorHofer approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one comment, LGTM.

@carlossanlop @ViktorHofer
Update NuGet.config
6579933 
Co-authored-by: Viktor Hofer <[email protected]>
This was referenced Aug 18, 2022
Closed
Closed
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Aug 18, 2022

Test failures are unrelated:

@carlossanlop carlossanlop changed the title Move dotnet7 feeds to dotnet8 in main nuget.config Add dotnet8 feeds in main nuget.config Aug 18, 2022
@carlossanlop carlossanlop merged commit 3db4524 into dotnet:main Aug 18, 2022
@carlossanlop carlossanlop deleted the NugetFeedDotnet8 branch August 18, 2022 03:00
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@ericstj ericstj Awaiting requested review from ericstj

+1 more reviewer

@smasher164 smasher164 smasher164 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlossanlop carlossanlop

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop @ViktorHofer @smasher164