-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Fix System.Object serialization with custom number handling #62193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
November 30, 2021 14:50
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsBackport of #62020 to release/6.0 /cc @eiriktsarpalis Customer ImpactTestingRisk
|
eiriktsarpalis
added
the
Servicing-consider
Issue for next servicing release review
label
Nov 30, 2021
Servicing approved over email. |
eiriktsarpalis
added
api-approved
API was approved in API review, it can be implemented
Servicing-approved
Approved for servicing release
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
and removed
Servicing-consider
Issue for next servicing release review
api-approved
API was approved in API review, it can be implemented
labels
Dec 1, 2021
stephentoub
approved these changes
Dec 1, 2021
safern
removed
the
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Dec 15, 2021
Closing and reopening to trigger CI again. |
steveharter
approved these changes
Dec 15, 2021
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.ReadTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.ReadTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.WriteTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/Object.WriteTests.cs
Outdated
Show resolved
Hide resolved
@eiriktsarpalis @ericstj do we need to address feedback here before 6.0.2 cutoff? |
Sure, I can help with that since @eiriktsarpalis is out. |
ghost
locked as resolved and limited conversation to collaborators
Feb 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62020 to release/6.0
/cc @eiriktsarpalis
Customer Impact
Addresses a customer-reported regression concerning serialization of
new object()
instances when used in conjunction with custom number handling. The regression was introduced by #54436 which refactored polymorphic serialization forobject
types but failed to account for custom number handling.Testing
Added regression tests that check for polymorphic serialization in custom number handling scenaria.
Risk
Low. This change impacts a rare corner case (serializing
new object()
instances).