From 54f9ff93123b56e42faa108bdeccc0699c36f5e7 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 22 Nov 2021 15:56:20 -0500 Subject: [PATCH 01/10] [wasm] Update chrome used for testing to latest stable Latest stable is `96.0.4664.45`, with `branch_base_position=929512`, and `929513` is the closest available build. --- src/libraries/sendtohelixhelp.proj | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/libraries/sendtohelixhelp.proj b/src/libraries/sendtohelixhelp.proj index 83eeca33b065d..249fdcdbcf429 100644 --- a/src/libraries/sendtohelixhelp.proj +++ b/src/libraries/sendtohelixhelp.proj @@ -364,15 +364,20 @@ Workloads- EMSDK- + + - - - 768968 + 929513 https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/$(ChromiumRevision)/chrome-linux.zip https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/$(ChromiumRevision)/chromedriver_linux64.zip - 768983 + 929513 https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/$(ChromiumRevision)/chrome-win.zip https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/$(ChromiumRevision)/chromedriver_win32.zip From 26c0b6dd9e0c4a75d9217ff22606db6c967e9420 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Sun, 21 Nov 2021 07:36:18 -0500 Subject: [PATCH 02/10] [wasm] Disable WBT tests failing on windows https://github.com/dotnet/runtime/issues/61725 --- src/tests/BuildWasmApps/Wasm.Build.Tests/MainWithArgsTests.cs | 2 ++ .../NativeRebuildTests/ReferenceNewAssemblyRebuildTest.cs | 2 ++ .../BuildWasmApps/Wasm.Build.Tests/SatelliteAssembliesTests.cs | 2 ++ .../BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj | 1 - src/tests/BuildWasmApps/Wasm.Build.Tests/WasmBuildAppTest.cs | 2 ++ 5 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/tests/BuildWasmApps/Wasm.Build.Tests/MainWithArgsTests.cs b/src/tests/BuildWasmApps/Wasm.Build.Tests/MainWithArgsTests.cs index b97a0490d2e87..73598d8b079b1 100644 --- a/src/tests/BuildWasmApps/Wasm.Build.Tests/MainWithArgsTests.cs +++ b/src/tests/BuildWasmApps/Wasm.Build.Tests/MainWithArgsTests.cs @@ -25,6 +25,7 @@ public MainWithArgsTests(ITestOutputHelper output, SharedBuildPerTestClassFixtur ).WithRunHosts(host).UnwrapItemsAsArrays(); [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61725", TestPlatforms.Windows)] [MemberData(nameof(MainWithArgsTestData), parameters: new object[] { /*aot*/ false, RunHost.All })] [MemberData(nameof(MainWithArgsTestData), parameters: new object[] { /*aot*/ true, RunHost.All })] public void AsyncMainWithArgs(BuildArgs buildArgs, string[] args, RunHost host, string id) @@ -39,6 +40,7 @@ public static async System.Threading.Tasks.Task Main(string[] args) buildArgs, args, host, id); [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61725", TestPlatforms.Windows)] [MemberData(nameof(MainWithArgsTestData), parameters: new object[] { /*aot*/ false, RunHost.All })] [MemberData(nameof(MainWithArgsTestData), parameters: new object[] { /*aot*/ true, RunHost.All })] public void TopLevelWithArgs(BuildArgs buildArgs, string[] args, RunHost host, string id) diff --git a/src/tests/BuildWasmApps/Wasm.Build.Tests/NativeRebuildTests/ReferenceNewAssemblyRebuildTest.cs b/src/tests/BuildWasmApps/Wasm.Build.Tests/NativeRebuildTests/ReferenceNewAssemblyRebuildTest.cs index 5aa3d2916f36f..d920ac400559a 100644 --- a/src/tests/BuildWasmApps/Wasm.Build.Tests/NativeRebuildTests/ReferenceNewAssemblyRebuildTest.cs +++ b/src/tests/BuildWasmApps/Wasm.Build.Tests/NativeRebuildTests/ReferenceNewAssemblyRebuildTest.cs @@ -1,6 +1,7 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. +using System; using System.IO; using System.Linq; using Wasm.Build.Tests; @@ -19,6 +20,7 @@ public ReferenceNewAssemblyRebuildTest(ITestOutputHelper output, SharedBuildPerT } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61725", TestPlatforms.Windows)] [MemberData(nameof(NativeBuildData))] public void ReferenceNewAssembly(BuildArgs buildArgs, bool nativeRelink, bool invariant, RunHost host, string id) { diff --git a/src/tests/BuildWasmApps/Wasm.Build.Tests/SatelliteAssembliesTests.cs b/src/tests/BuildWasmApps/Wasm.Build.Tests/SatelliteAssembliesTests.cs index 3532028dcc491..b65c274ae62ed 100644 --- a/src/tests/BuildWasmApps/Wasm.Build.Tests/SatelliteAssembliesTests.cs +++ b/src/tests/BuildWasmApps/Wasm.Build.Tests/SatelliteAssembliesTests.cs @@ -29,6 +29,7 @@ public SatelliteAssembliesTests(ITestOutputHelper output, SharedBuildPerTestClas .UnwrapItemsAsArrays(); [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61725", TestPlatforms.Windows)] [MemberData(nameof(SatelliteAssemblyTestData), parameters: new object[] { /*aot*/ false, /*relinking*/ false, RunHost.All })] [MemberData(nameof(SatelliteAssemblyTestData), parameters: new object[] { /*aot*/ false, /*relinking*/ true, RunHost.All })] [MemberData(nameof(SatelliteAssemblyTestData), parameters: new object[] { /*aot*/ true, /*relinking*/ false, RunHost.All })] @@ -66,6 +67,7 @@ public void ResourcesFromMainAssembly(BuildArgs buildArgs, } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61725", TestPlatforms.Windows)] [MemberData(nameof(SatelliteAssemblyTestData), parameters: new object[] { /*aot*/ false, /*relinking*/ false, RunHost.All })] [MemberData(nameof(SatelliteAssemblyTestData), parameters: new object[] { /*aot*/ false, /*relinking*/ true, RunHost.All })] [MemberData(nameof(SatelliteAssemblyTestData), parameters: new object[] { /*aot*/ true, /*relinking*/ false, RunHost.All })] diff --git a/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj b/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj index 445e6c6d0987e..9411e65e0be56 100644 --- a/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj +++ b/src/tests/BuildWasmApps/Wasm.Build.Tests/Wasm.Build.Tests.csproj @@ -1,7 +1,6 @@ $(NetCoreAppToolCurrent) - true true true true diff --git a/src/tests/BuildWasmApps/Wasm.Build.Tests/WasmBuildAppTest.cs b/src/tests/BuildWasmApps/Wasm.Build.Tests/WasmBuildAppTest.cs index 412bf4a3da2ea..68bc578754c04 100644 --- a/src/tests/BuildWasmApps/Wasm.Build.Tests/WasmBuildAppTest.cs +++ b/src/tests/BuildWasmApps/Wasm.Build.Tests/WasmBuildAppTest.cs @@ -21,6 +21,7 @@ public WasmBuildAppTest(ITestOutputHelper output, SharedBuildPerTestClassFixture .UnwrapItemsAsArrays(); [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61725", TestPlatforms.Windows)] [MemberData(nameof(MainMethodTestData), parameters: new object[] { /*aot*/ true, RunHost.All })] [MemberData(nameof(MainMethodTestData), parameters: new object[] { /*aot*/ false, RunHost.All })] public void TopLevelMain(BuildArgs buildArgs, RunHost host, string id) @@ -29,6 +30,7 @@ public void TopLevelMain(BuildArgs buildArgs, RunHost host, string id) buildArgs, host, id); [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61725", TestPlatforms.Windows)] [MemberData(nameof(MainMethodTestData), parameters: new object[] { /*aot*/ true, RunHost.All })] [MemberData(nameof(MainMethodTestData), parameters: new object[] { /*aot*/ false, RunHost.All })] public void AsyncMain(BuildArgs buildArgs, RunHost host, string id) From e97a2716dc0b42827081151b86914cf865987c09 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 22 Nov 2021 16:02:03 -0500 Subject: [PATCH 03/10] [wasm][aot] Don't try to run the tests, if AOT build fails --- eng/testing/tests.wasm.targets | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eng/testing/tests.wasm.targets b/eng/testing/tests.wasm.targets index 000316cfd46d5..0286959859cc1 100644 --- a/eng/testing/tests.wasm.targets +++ b/eng/testing/tests.wasm.targets @@ -10,7 +10,8 @@ so, just setting it true by default --> true - <_ShellCommandSeparator Condition="'$(OS)' == 'Windows_NT'">& + + <_ShellCommandSeparator Condition="'$(OS)' == 'Windows_NT'">&& <_ShellCommandSeparator Condition="'$(OS)' != 'Windows_NT'">&& From dd0a32841fc112589493914ec69a98af57584f03 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 22 Nov 2021 16:09:07 -0500 Subject: [PATCH 04/10] [wasm] Disable AOT builds on windows Issue: https://github.com/dotnet/runtime/issues/61721 --- eng/pipelines/runtime-manual.yml | 81 ++++++++++++++++--------------- eng/pipelines/runtime-staging.yml | 81 ++++++++++++++++--------------- 2 files changed, 82 insertions(+), 80 deletions(-) diff --git a/eng/pipelines/runtime-manual.yml b/eng/pipelines/runtime-manual.yml index e79f469471bde..dadcf9b5cc914 100644 --- a/eng/pipelines/runtime-manual.yml +++ b/eng/pipelines/runtime-manual.yml @@ -333,46 +333,47 @@ jobs: eq(variables['isManualOrIsNotPR'], true), eq(variables['isFullMatrix'], true)) -- template: /eng/pipelines/common/platform-matrix.yml - parameters: - jobTemplate: /eng/pipelines/common/global-build-job.yml - helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml - buildConfig: release - runtimeFlavor: mono - platforms: - - Browser_wasm_win - variables: - # map dependencies variables to local variables - - name: librariesContainsChange - value: $[ dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'] ] - - name: monoContainsChange - value: $[ dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'] ] - jobParameters: - testGroup: innerloop - nameSuffix: Windows_wasm_AOT - buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BrowserHost=windows /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=true $(_runSmokeTestsOnlyArg) - timeoutInMinutes: 180 - condition: >- - or( - eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), - eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true), - eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), - eq(variables['isManualOrIsNotPR'], true), - eq(variables['isFullMatrix'], true)) - # extra steps, run tests - extraStepsTemplate: /eng/pipelines/libraries/helix.yml - extraStepsParameters: - creator: dotnet-bot - testRunNamePrefixSuffix: Mono_$(_BuildConfig) - extraHelixArguments: /p:BrowserHost=windows /p:NeedsToBuildWasmAppsOnHelix=true $(_runSmokeTestsOnlyArg) - scenarios: - - normal - condition: >- - or( - eq(variables['librariesContainsChange'], true), - eq(variables['monoContainsChange'], true), - eq(variables['isManualOrIsNotPR'], true), - eq(variables['isFullMatrix'], true)) +# Disabled due to https://github.com/dotnet/runtime/issues/61721 +#- template: /eng/pipelines/common/platform-matrix.yml + #parameters: + #jobTemplate: /eng/pipelines/common/global-build-job.yml + #helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml + #buildConfig: release + #runtimeFlavor: mono + #platforms: + #- Browser_wasm_win + #variables: + ## map dependencies variables to local variables + #- name: librariesContainsChange + #value: $[ dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'] ] + #- name: monoContainsChange + #value: $[ dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'] ] + #jobParameters: + #testGroup: innerloop + #nameSuffix: Windows_wasm_AOT + #buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BrowserHost=windows /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=true $(_runSmokeTestsOnlyArg) + #timeoutInMinutes: 180 + #condition: >- + #or( + #eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), + #eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true), + #eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), + #eq(variables['isManualOrIsNotPR'], true), + #eq(variables['isFullMatrix'], true)) + ## extra steps, run tests + #extraStepsTemplate: /eng/pipelines/libraries/helix.yml + #extraStepsParameters: + #creator: dotnet-bot + #testRunNamePrefixSuffix: Mono_$(_BuildConfig) + #extraHelixArguments: /p:BrowserHost=windows /p:NeedsToBuildWasmAppsOnHelix=true $(_runSmokeTestsOnlyArg) + #scenarios: + #- normal + #condition: >- + #or( + #eq(variables['librariesContainsChange'], true), + #eq(variables['monoContainsChange'], true), + #eq(variables['isManualOrIsNotPR'], true), + #eq(variables['isFullMatrix'], true)) # # Build for Browser/wasm, with EnableAggressiveTrimming=true diff --git a/eng/pipelines/runtime-staging.yml b/eng/pipelines/runtime-staging.yml index fa634a1e571d2..fc92ac20f4d78 100644 --- a/eng/pipelines/runtime-staging.yml +++ b/eng/pipelines/runtime-staging.yml @@ -493,46 +493,47 @@ jobs: # # Build Browser_wasm, on windows, and run tests with AOT # -- template: /eng/pipelines/common/platform-matrix.yml - parameters: - jobTemplate: /eng/pipelines/common/global-build-job.yml - helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml - buildConfig: release - runtimeFlavor: mono - platforms: - - Browser_wasm_win - variables: - # map dependencies variables to local variables - - name: librariesContainsChange - value: $[ dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'] ] - - name: monoContainsChange - value: $[ dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'] ] - jobParameters: - testGroup: innerloop - nameSuffix: Windows_wasm_AOT - buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BrowserHost=windows /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=true $(_runSmokeTestsOnlyArg) - timeoutInMinutes: 180 - condition: >- - or( - eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), - eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true), - eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), - eq(variables['isManualOrIsNotPR'], true), - eq(variables['isFullMatrix'], true)) - # extra steps, run tests - extraStepsTemplate: /eng/pipelines/libraries/helix.yml - extraStepsParameters: - creator: dotnet-bot - testRunNamePrefixSuffix: Mono_$(_BuildConfig) - extraHelixArguments: /p:BrowserHost=windows /p:NeedsToBuildWasmAppsOnHelix=true $(_runSmokeTestsOnlyArg) - scenarios: - - normal - condition: >- - or( - eq(variables['librariesContainsChange'], true), - eq(variables['monoContainsChange'], true), - eq(variables['isManualOrIsNotPR'], true), - eq(variables['isFullMatrix'], true)) +# Disabled due to https://github.com/dotnet/runtime/issues/61721 +#- template: /eng/pipelines/common/platform-matrix.yml + #parameters: + #jobTemplate: /eng/pipelines/common/global-build-job.yml + #helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml + #buildConfig: release + #runtimeFlavor: mono + #platforms: + #- Browser_wasm_win + #variables: + ## map dependencies variables to local variables + #- name: librariesContainsChange + #value: $[ dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'] ] + #- name: monoContainsChange + #value: $[ dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'] ] + #jobParameters: + #testGroup: innerloop + #nameSuffix: Windows_wasm_AOT + #buildArgs: -s mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BrowserHost=windows /p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=true $(_runSmokeTestsOnlyArg) + #timeoutInMinutes: 180 + #condition: >- + #or( + #eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true), + #eq(dependencies.evaluate_paths.outputs['SetPathVars_mono.containsChange'], true), + #eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), + #eq(variables['isManualOrIsNotPR'], true), + #eq(variables['isFullMatrix'], true)) + ## extra steps, run tests + #extraStepsTemplate: /eng/pipelines/libraries/helix.yml + #extraStepsParameters: + #creator: dotnet-bot + #testRunNamePrefixSuffix: Mono_$(_BuildConfig) + #extraHelixArguments: /p:BrowserHost=windows /p:NeedsToBuildWasmAppsOnHelix=true $(_runSmokeTestsOnlyArg) + #scenarios: + #- normal + #condition: >- + #or( + #eq(variables['librariesContainsChange'], true), + #eq(variables['monoContainsChange'], true), + #eq(variables['isManualOrIsNotPR'], true), + #eq(variables['isFullMatrix'], true)) # From e580ee416fd2441a3157ba7862f533c69a8bedfe Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 22 Nov 2021 18:53:00 -0500 Subject: [PATCH 05/10] [wasm] Disable JS Interop failing tests https://github.com/dotnet/runtime/issues/61945 --- .../InteropServices/JavaScript/JavaScriptTests.cs | 1 + .../InteropServices/JavaScript/SharedArrayBufferTests.cs | 1 + .../InteropServices/JavaScript/TypedArrayTests.cs | 9 +++++++++ 3 files changed, 11 insertions(+) diff --git a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/JavaScriptTests.cs b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/JavaScriptTests.cs index 7158c38899c13..146575af36838 100644 --- a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/JavaScriptTests.cs +++ b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/JavaScriptTests.cs @@ -11,6 +11,7 @@ namespace System.Runtime.InteropServices.JavaScript.Tests public static class JavaScriptTests { [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] public static void CoreTypes() { var arr = new Uint8ClampedArray(50); diff --git a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/SharedArrayBufferTests.cs b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/SharedArrayBufferTests.cs index 7ca2e660a4e9a..d5b7df4cc34cf 100644 --- a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/SharedArrayBufferTests.cs +++ b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/SharedArrayBufferTests.cs @@ -6,6 +6,7 @@ namespace System.Runtime.InteropServices.JavaScript.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] public static class SharedArrayBufferTests { private static Function _objectPrototype; diff --git a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/TypedArrayTests.cs b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/TypedArrayTests.cs index 896835795f198..0b7075893a40d 100644 --- a/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/TypedArrayTests.cs +++ b/src/libraries/System.Private.Runtime.InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/TypedArrayTests.cs @@ -108,6 +108,7 @@ public static void Float64ArrayFrom(Function objectPrototype) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Uint8ClampedArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -117,6 +118,7 @@ public static void Uint8ClampedArrayFromSharedArrayBuffer(Function objectPrototy } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Uint8ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -126,6 +128,7 @@ public static void Uint8ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Uint16ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -135,6 +138,7 @@ public static void Uint16ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Uint32ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -144,6 +148,7 @@ public static void Uint32ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Int8ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -153,6 +158,7 @@ public static void Int8ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Int16ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -162,6 +168,7 @@ public static void Int16ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Int32ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -171,6 +178,7 @@ public static void Int32ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Float32ArrayFromSharedArrayBuffer(Function objectPrototype) { @@ -180,6 +188,7 @@ public static void Float32ArrayFromSharedArrayBuffer(Function objectPrototype) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/61945", TestPlatforms.Browser)] [MemberData(nameof(Object_Prototype))] public static void Float64ArrayFromSharedArrayBuffer(Function objectPrototype) { From 80cf2c94bfc3313ed157e8ab9615776231e39aaf Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 22 Nov 2021 18:59:06 -0500 Subject: [PATCH 06/10] [wasm] Enable windows tests on manual runs --- eng/pipelines/runtime-staging.yml | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/eng/pipelines/runtime-staging.yml b/eng/pipelines/runtime-staging.yml index fc92ac20f4d78..a9b8ab734d959 100644 --- a/eng/pipelines/runtime-staging.yml +++ b/eng/pipelines/runtime-staging.yml @@ -473,22 +473,21 @@ jobs: eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), eq(variables['isManualOrIsNotPR'], true), eq(variables['isFullMatrix'], true)) - ${{ if eq(variables['isFullMatrix'], true) }}: - # extra steps, run tests - extraStepsTemplate: /eng/pipelines/libraries/helix.yml - extraStepsParameters: - creator: dotnet-bot - testRunNamePrefixSuffix: Mono_$(_BuildConfig) - extraHelixArguments: /p:BrowserHost=windows - scenarios: - - normal - - wasmtestonbrowser - condition: >- - or( - eq(variables['librariesContainsChange'], true), - eq(variables['monoContainsChange'], true), - eq(variables['isManualOrIsNotPR'], true), - eq(variables['isFullMatrix'], true)) + # extra steps, run tests + extraStepsTemplate: /eng/pipelines/libraries/helix.yml + extraStepsParameters: + creator: dotnet-bot + testRunNamePrefixSuffix: Mono_$(_BuildConfig) + extraHelixArguments: /p:BrowserHost=windows + scenarios: + - normal + - wasmtestonbrowser + condition: >- + or( + eq(variables['librariesContainsChange'], true), + eq(variables['monoContainsChange'], true), + eq(variables['isManualOrIsNotPR'], true), + eq(variables['isFullMatrix'], true)) # # Build Browser_wasm, on windows, and run tests with AOT From 61c135de840e7593dab9e76be9afc398c26efa4a Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Mon, 22 Nov 2021 19:44:17 -0500 Subject: [PATCH 07/10] [wasm] honor RunSmokeTestsOnly --- eng/pipelines/runtime-manual.yml | 31 +++++++++++++++---------------- eng/pipelines/runtime-staging.yml | 2 +- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/eng/pipelines/runtime-manual.yml b/eng/pipelines/runtime-manual.yml index dadcf9b5cc914..83f9e891dab57 100644 --- a/eng/pipelines/runtime-manual.yml +++ b/eng/pipelines/runtime-manual.yml @@ -280,22 +280,21 @@ jobs: eq(dependencies.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true), eq(variables['isManualOrIsNotPR'], true), eq(variables['isFullMatrix'], true)) - ${{ if eq(variables['isFullMatrix'], true) }}: - # extra steps, run tests - extraStepsTemplate: /eng/pipelines/libraries/helix.yml - extraStepsParameters: - creator: dotnet-bot - testRunNamePrefixSuffix: Mono_$(_BuildConfig) - extraHelixArguments: /p:BrowserHost=windows - scenarios: - - normal - - wasmtestonbrowser - condition: >- - or( - eq(variables['librariesContainsChange'], true), - eq(variables['monoContainsChange'], true), - eq(variables['isManualOrIsNotPR'], true), - eq(variables['isFullMatrix'], true)) + # extra steps, run tests + extraStepsTemplate: /eng/pipelines/libraries/helix.yml + extraStepsParameters: + creator: dotnet-bot + testRunNamePrefixSuffix: Mono_$(_BuildConfig) + extraHelixArguments: /p:BrowserHost=windows + scenarios: + - normal + - wasmtestonbrowser + condition: >- + or( + eq(variables['librariesContainsChange'], true), + eq(variables['monoContainsChange'], true), + eq(variables['isManualOrIsNotPR'], true), + eq(variables['isFullMatrix'], true)) - template: /eng/pipelines/common/platform-matrix.yml parameters: diff --git a/eng/pipelines/runtime-staging.yml b/eng/pipelines/runtime-staging.yml index a9b8ab734d959..d96492554de79 100644 --- a/eng/pipelines/runtime-staging.yml +++ b/eng/pipelines/runtime-staging.yml @@ -478,7 +478,7 @@ jobs: extraStepsParameters: creator: dotnet-bot testRunNamePrefixSuffix: Mono_$(_BuildConfig) - extraHelixArguments: /p:BrowserHost=windows + extraHelixArguments: /p:BrowserHost=windows $(_runSmokeTestsOnlyArg) scenarios: - normal - wasmtestonbrowser From 23e77cbda9554630d0d9bb5b0678876ebdf85272 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Tue, 23 Nov 2021 17:26:14 +0000 Subject: [PATCH 08/10] Update src/libraries/sendtohelixhelp.proj Co-authored-by: Radek Doulik --- src/libraries/sendtohelixhelp.proj | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/libraries/sendtohelixhelp.proj b/src/libraries/sendtohelixhelp.proj index 249fdcdbcf429..50ea41552f9c0 100644 --- a/src/libraries/sendtohelixhelp.proj +++ b/src/libraries/sendtohelixhelp.proj @@ -367,9 +367,12 @@ 929513 From bd44d3db23575a99e8cd0c9695ab8e4a006ff247 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Tue, 23 Nov 2021 16:51:43 -0500 Subject: [PATCH 09/10] [wasm][win] fix wasm/windows networking test failures `System.Net.WebSockets.Client.Tests`, and `System.Net.Http.Functional.Tests` fail because the echo servers don't get included in the helix payload. - Don't condition the inclusion on `RunSmokeTestsOnly`, instead it will be included only if it was built, and that would depend correctly on `RunSmokeTestsOnly`. - Pass the smoke test argument to the build command line for wasm/windows --- eng/pipelines/runtime-staging.yml | 2 +- src/libraries/sendtohelixhelp.proj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/pipelines/runtime-staging.yml b/eng/pipelines/runtime-staging.yml index d96492554de79..a38deea1927a5 100644 --- a/eng/pipelines/runtime-staging.yml +++ b/eng/pipelines/runtime-staging.yml @@ -464,7 +464,7 @@ jobs: jobParameters: testGroup: innerloop nameSuffix: Windows_wasm - buildArgs: -subset mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BrowserHost=windows + buildArgs: -subset mono+libs+host+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BrowserHost=windows $(_runSmokeTestsOnlyArg) timeoutInMinutes: 180 condition: >- or( diff --git a/src/libraries/sendtohelixhelp.proj b/src/libraries/sendtohelixhelp.proj index 50ea41552f9c0..0301570b12655 100644 --- a/src/libraries/sendtohelixhelp.proj +++ b/src/libraries/sendtohelixhelp.proj @@ -439,7 +439,7 @@ - + From f3a7b51227d9beade27ad895a2a7be56e58ae1e3 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Tue, 23 Nov 2021 17:47:07 -0500 Subject: [PATCH 10/10] Add condition to ensure that the middleware exists --- src/libraries/sendtohelixhelp.proj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/sendtohelixhelp.proj b/src/libraries/sendtohelixhelp.proj index 0301570b12655..c3f4fc1549607 100644 --- a/src/libraries/sendtohelixhelp.proj +++ b/src/libraries/sendtohelixhelp.proj @@ -440,8 +440,8 @@ - - + +