Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Debug on firefox #61776

Merged
merged 158 commits into from
Apr 26, 2022
Merged

[wasm][debugger] Debug on firefox #61776

merged 158 commits into from
Apr 26, 2022

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Nov 18, 2021

It's working both on VS and on Firefox:

  • step
  • resume
  • see locals
  • callstack
  • evaluate expressions
  • show properties

To Do:

MicrosoftTeams-image

MicrosoftTeams-image2

@ghost
Copy link

ghost commented Nov 18, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

It's working both on VS and on Firefox:

  • step
  • resume
  • see locals
  • callstack

To Do:

  • receive more than one connection
  • I think the line number is wrong (by +/-1)
  • evaluate expressions

MicrosoftTeams-image

MicrosoftTeams-image2

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg marked this pull request as draft November 18, 2021 14:11
@thaystg thaystg requested review from lewing and radical November 18, 2021 14:11
- Skip properties
- Get array value from evaluateAsyncJS and not use the preview value.
@ghost ghost closed this Dec 22, 2021
@ghost
Copy link

ghost commented Dec 22, 2021

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 22, 2022
@thaystg thaystg reopened this Feb 7, 2022
@thaystg
Copy link
Member Author

thaystg commented Feb 17, 2022

@radical when you have time, can you please start the review?

@radical
Copy link
Member

radical commented Apr 22, 2022

/azp run runtime-staging

@thaystg
Copy link
Member Author

thaystg commented Apr 26, 2022

Tested on Firefox and on Chrome debugging a Blazor app and both are working :)

@thaystg thaystg merged commit a970720 into dotnet:main Apr 26, 2022
@ilonatommy
Copy link
Member

/azp run runtime-staging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants