-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable tests unstable on Windows 11 #59135
Conversation
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Detailscontributes to #58927 cc: @ViktorHofer
|
@@ -66,11 +67,18 @@ public static IEnumerable<object[]> SslStream_StreamToStream_Authentication_Succ | |||
} | |||
} | |||
|
|||
[Theory] | |||
[ConditionalTheory] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ConditionalTheory
if there are no actual conditions passed to it? Is it needed for SkipTestException
to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's necessary for SkipTestException
to work. The condition isn't statically defined but dynamically via throwing an Exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW this is our own extension and that is also why Microsoft.DotNet.XUnitExtensions is needed @antonfirsov
Unrelated test failure in System.ComponentModel.EventBasedAsync.Tests:
Re-running failed leg |
@karelz thanks for pointing out the unrelated test failure. What would help even more is if you could file an issue for it (in this case one doesn't exist yet) so that this information isn't lost in the nirvana of merged PRs. |
@ViktorHofer I am hesitant to file one off test failures as they are super-noisy in Networking for example (we close them right away) -- IMO people searching for it will find the PR and if they see it 2nd time, they can create issue ... optimizing for process ;) |
The official guidance has been to open issues for every unrelated test failure immediately so that area owners can look into the failures and triage them. In some cases such failures might just be noise (still our tests needs to handle that) but in other cases they might surface an underlying product issue. |
/backport to release/6.0 |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1670024962 |
contributes to #58927
cc: @ViktorHofer