Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][aot] Force python to default to UTF8 #53557

Merged
merged 2 commits into from
Jun 2, 2021
Merged

[wasm][aot] Force python to default to UTF8 #53557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c731714
[wasm][aot] Force python to default to UTF8
radical Jun 1, 2021
be6450b
Merge remote-tracking branch 'origin/main' into fix-python-utf8
radical Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/mono/wasm/build/WasmApp.Native.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,15 @@

<ItemGroup>
<EmscriptenEnvVars Include="PATH=$(_EmscriptenPrependPATHProperty)$(_PathSeparator)$([MSBuild]::Escape($(PATH)))" />

<!--
Python defaults to the system charset, and thus expects the files it's reading to
match that. But that might not always be true. Eg. system charset=gbk, failing to read
utf-8 files

See https://github.com/dotnet/runtime/issues/53367 for the motivating issue
-->
<EmscriptenEnvVars Include="PYTHONUTF8=1" />
</ItemGroup>
</Target>

Expand Down