Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][aot] Force python to default to UTF8 #53557

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

radical
Copy link
Member

@radical radical commented Jun 1, 2021

Fixes #53367

@ghost
Copy link

ghost commented Jun 1, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #53367

Author: radical
Assignees: -
Labels:

area-VM-meta-mono

Milestone: -

@radical radical force-pushed the fix-python-utf8 branch from eb6772b to c731714 Compare June 1, 2021 22:53
@radical
Copy link
Member Author

radical commented Jun 2, 2021

hm browser run fails with:

warn: /__w/1/s/src/mono/mono/utils/memfuncs.c:360 <disabled>

info: {"method":"console.error","payload":{},"arguments":[{}]}
fail: Error: System.NullReferenceException: Object reference not set to an instance of an object.
         at System.Runtime.InteropServices.JavaScript.Runtime.<>c__DisplayClass27_0.<SetupJSContinuation>g__Complete|0()
         at System.Runtime.InteropServices.JavaScript.Runtime.SetupJSContinuation(Task task, JSObject continuationObj)
         at Object._convert_exception_for_method_call (http://127.0.0.1:41301/dotnet.js:1:196628)
         at Object._handle_exception_for_call (http://127.0.0.1:41301/dotnet.js:1:198597)
         at Object._handle_exception_and_produce_result_for_call (http://127.0.0.1:41301/dotnet.js:1:198918)
         at Object._call_method_with_converted_args (http://127.0.0.1:41301/dotnet.js:1:199992)
         at Object.call_method (http://127.0.0.1:41301/dotnet.js:1:198387)
         at Object._unbox_task_rooted (http://127.0.0.1:41301/dotnet.js:1:177443)
         at Object._unbox_mono_obj_rooted_with_known_nonprimitive_type (http://127.0.0.1:41301/dotnet.js:1:178374)
         at Object._unbox_mono_obj_root (http://127.0.0.1:41301/dotnet.js:1:179611)
         at Object._handle_exception_and_produce_result_for_call (http://127.0.0.1:41301/dotnet.js:1:199038)
         at Object._call_method_with_converted_args (http://127.0.0.1:41301/dotnet.js:1:199992)

It shouldn't be related to this PR, but I have merged main, and let's see if it fails again.

@radical radical merged commit a71ea4d into dotnet:main Jun 2, 2021
@radical radical deleted the fix-python-utf8 branch June 2, 2021 17:41
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error if user in no python utf8 encoding ENV to run blazor AOT
2 participants