Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate selected changes from nativeaot branch #53185

Closed
wants to merge 2 commits into from
Closed

Integrate selected changes from nativeaot branch #53185

wants to merge 2 commits into from

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 24, 2021

  • More code sharing for System.Exception
  • Some support for default interface methods
  • Move callling convention helpers around to avoid duplication

@jkotas
Integrate selected changes from nativeaot branch
a3859fa 
- More code sharing for System.Exception
- Some support for default interface methods
- Move callling convention helpers around to avoid duplication
@jkotas jkotas requested a review from marek-safar as a code owner May 24, 2021 18:03
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas jkotas requested a review from MichalStrehovsky May 24, 2021 18:03
MichalStrehovsky
MichalStrehovsky approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas
Copy link
Member Author

jkotas commented May 25, 2021

Committed as 517421c

1 similar comment
@jkotas
Copy link
Member Author

jkotas commented May 25, 2021

Committed as 517421c

@jkotas jkotas closed this May 25, 2021
@jkotas jkotas deleted the nativeaot branch May 25, 2021 15:19
monojenkins pushed a commit to monojenkins/runtime that referenced this pull request May 25, 2021
@jkotas
Integrate selected changes from nativeaot branch (dotnet#53185)
517421c 
- More code sharing for System.Exception
- Some support for default interface methods
- Move callling convention helpers around to avoid duplication
- Unify Environment.StackTrace
@runfoapp runfoapp bot mentioned this pull request Jun 2, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @MichalStrehovsky