Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stringify RMWStatus for the dump #53148

Merged
merged 3 commits into from
May 24, 2021
Merged

Stringify RMWStatus for the dump #53148

merged 3 commits into from
May 24, 2021

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented May 23, 2021 •
edited
Loading

Before:

Lower of StoreInd didn't mark the node as self contained for reason: 3

After:

Lower of StoreInd didn't mark the node as self contained for reason: oper is not supported

cc @tannergooding @kunalspathak

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 23, 2021
@SingleAccretion
Copy link
Contributor Author

@kunalspathak reworked as per the suggestion, PTAL.

kunalspathak
kunalspathak approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kunalspathak kunalspathak merged commit 51b6188 into dotnet:main May 24, 2021
@SingleAccretion SingleAccretion deleted the Stringify-RMWStatus-In-Dumps branch May 24, 2021 17:07
@runfoapp runfoapp bot mentioned this pull request Jun 2, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SingleAccretion @kunalspathak