[release/6.0-preview5] Rename Mac Catalyst dylib to libmonosgen, not libcoreclr #53076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This fix worked fine for the main branch (and we need this for P5). Any chance this can be merged asap? |
|
This awaiting tactics approval. |
|
If it helps we are blocked by this for actually incorporating P5 so without this we are really in trouble. |
leecow
added
Servicing-approved
Anipik
approved these changes
May 25, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #53038 to release/6.0-preview5
/cc @akoeplinger @directhex
Customer Impact
The MacCatalyst MonoVM runtime packs didn't contain a (dynamic) libmonosgen-2.0.dylib because we were renaming it to libcoreclr.dylib which was supposed to only happen on Desktop.
This unblocks Xamarin to bump to Preview5 builds.
Testing
Manual testing.
Risk
Low, just renames a file.