Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JIT] Improve inliner: new heuristics, rely on PGO data #52708

Merged
merged 67 commits into from
Jul 1, 2021
Merged

[JIT] Improve inliner: new heuristics, rely on PGO data #52708

merged 67 commits into from
Jul 1, 2021

Commits on Jun 10, 2021

  1. Port old changes

    @EgorBo
    EgorBo committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    d8e2d7c View commit details
    Browse the repository at this point in the history

  2. Improvements

    @EgorBo
    EgorBo committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    98afcea View commit details
    Browse the repository at this point in the history

  3. Limit it for loops

    @EgorBo
    EgorBo committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    9a01fe3 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    7e4fba2 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2021

  1. Tuning

    @EgorBo
    EgorBo committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    4bc7341 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2021

  1. Make it less aggressive (esp. for R2R)

    @EgorBo
    EgorBo committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    52a8e8b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Bring back the previous algorithm just in case (available under a con… 

    …fig switch)
    @EgorBo
    EgorBo committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    d2d1d15 View commit details
    Browse the repository at this point in the history

  2. Bring back the previous algorithm just in case (available under a con… 

    …fig switch)
    @EgorBo
    EgorBo committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    a8c981c View commit details
    Browse the repository at this point in the history

  3. Bring back the previous algorithm just in case (available under a con… 

    …fig switch)
    @EgorBo
    EgorBo committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    06f91d9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    cc8a179 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @EgorBo
    EgorBo committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    1d18d4e View commit details
    Browse the repository at this point in the history

  6. Make formatter happy

    @EgorBo
    EgorBo committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    94e803f View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Introduce a new policy

    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    244dffe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    8081492 View commit details
    Browse the repository at this point in the history

  3. Introduce a new policy

    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    3adc9c1 View commit details
    Browse the repository at this point in the history

  4. Introduce a new policy

    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    1d2c37b View commit details
    Browse the repository at this point in the history

  5. Clean up

    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    6a3e69a View commit details
    Browse the repository at this point in the history

  6. Use ExtendedDefaultPolicy by default (except non-rootprejt R2R)

    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    f0409ac View commit details
    Browse the repository at this point in the history

  7. Fix CI

    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    244abb4 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    efabef6 View commit details
    Browse the repository at this point in the history

  9. Address feedback

    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    d1c7c10 View commit details
    Browse the repository at this point in the history

  10. Update src/coreclr/jit/inlinepolicy.cpp 

    Co-authored-by: Andy Ayers <[email protected]>
    @EgorBo @AndyAyersMS
    EgorBo and AndyAyersMS authored Jun 15, 2021
    Configuration menu
    Copy the full SHA
    d03d9ba View commit details
    Browse the repository at this point in the history

  11. Update src/coreclr/jit/jitconfigvalues.h 

    Co-authored-by: Andy Ayers <[email protected]>
    @EgorBo @AndyAyersMS
    EgorBo and AndyAyersMS authored Jun 15, 2021
    Configuration menu
    Copy the full SHA
    d991d46 View commit details
    Browse the repository at this point in the history

  12. Fix ci

    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    1c123fb View commit details
    Browse the repository at this point in the history

  13. Make formatter job happy

    @EgorBo
    EgorBo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    3cfb759 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Experiment.

    @EgorBo
    EgorBo committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    ed1606d View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    19eed26 View commit details
    Browse the repository at this point in the history

  2. Tuning

    @EgorBo
    EgorBo committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    5298b26 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    2e367e2 View commit details
    Browse the repository at this point in the history

  4. Tuning

    @EgorBo
    EgorBo committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    0977ffd View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Tuning

    @EgorBo
    EgorBo committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    2f5331d View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Tuning

    @EgorBo
    EgorBo committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    d46eb87 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    b6a4423 View commit details
    Browse the repository at this point in the history

  3. Tuning

    @EgorBo
    EgorBo committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    dbbc828 View commit details
    Browse the repository at this point in the history

  4. Tuning

    @EgorBo
    EgorBo committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    d752348 View commit details
    Browse the repository at this point in the history

  5. Tuning

    @EgorBo
    EgorBo committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    3307b71 View commit details
    Browse the repository at this point in the history

  6. Less aggressive version.

    @EgorBo
    EgorBo committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    20dec2c View commit details
    Browse the repository at this point in the history

  7. Less aggressive version.

    @EgorBo
    EgorBo committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    cb3c6a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. Clean up.

    @EgorBo
    EgorBo committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    a7584c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Tuning

    @EgorBo
    EgorBo committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    828b049 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    dbd3a63 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c8479a1 View commit details
    Browse the repository at this point in the history

  4. Make it less aggressive.

    @EgorBo
    EgorBo committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    4148fb4 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Fix XML dump

    @EgorBo
    EgorBo committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    bf474fe View commit details
    Browse the repository at this point in the history

  2. Reduce prejit size by 100kb

    @EgorBo
    EgorBo committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    2f3bc1b View commit details
    Browse the repository at this point in the history

  3. Reduce prejit size by 100kb

    @EgorBo
    EgorBo committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    a6cb278 View commit details
    Browse the repository at this point in the history

  4. Better parameters (10.15 Mb or +5% size)

    @EgorBo
    EgorBo committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    45f0b2f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    53a5ef6 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Fix regression (new size: 10.11Mb)

    @EgorBo
    EgorBo committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    4c5ec4e View commit details
    Browse the repository at this point in the history

  2. Fix regressions (size is still 10.1Mb)

    @EgorBo
    EgorBo committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    34ecc08 View commit details
    Browse the repository at this point in the history

  3. Fix regressions

    @EgorBo
    EgorBo committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    3403cef View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Make it even less aggressive (10.01Mb)

    @EgorBo
    EgorBo committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    cc6c1ec View commit details
    Browse the repository at this point in the history

  2. Formatting

    @EgorBo
    EgorBo committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    bec02d1 View commit details
    Browse the repository at this point in the history

  3. Fix regressions

    @EgorBo
    EgorBo committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    6e9678f View commit details
    Browse the repository at this point in the history

  4. Don't perform stloc/ldloc on non-precise scan

    @EgorBo
    EgorBo committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    f16cc31 View commit details
    Browse the repository at this point in the history

  5. Fix regressions

    @EgorBo
    EgorBo committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    05a19e5 View commit details
    Browse the repository at this point in the history

  6. Slow down inlining if we already have to many locals in the rootCompi… 

    …ler.
    @EgorBo
    EgorBo committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    04dfc2e View commit details
    Browse the repository at this point in the history

  7. Formatting

    @EgorBo
    EgorBo committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    a86c067 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    57e4893 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. Fix regressions

    @EgorBo
    EgorBo committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    15d9a0d View commit details
    Browse the repository at this point in the history

  2. Better default parameters

    @EgorBo
    EgorBo committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    e072cc6 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Address feedback

    @EgorBo
    EgorBo committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    914f58b View commit details
    Browse the repository at this point in the history

  2. Formatting

    @EgorBo
    EgorBo committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    ae02160 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Fix speed_opt check (it's not set for normal jit)

    @EgorBo
    EgorBo committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    2337ddc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    397546a View commit details
    Browse the repository at this point in the history

  3. Remove JitExtDefaultPolicyProfBB and handle CEE_IND over arguments

    @EgorBo
    EgorBo committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    28de069 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/dotnet/runtime into jit-inl… 

    …iner-improvements
    @EgorBo
    EgorBo committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    43d353f View commit details
    Browse the repository at this point in the history