From ce488e9188ce5888e9d099ade0876bea985d8f2f Mon Sep 17 00:00:00 2001 From: SingleAccretion Date: Thu, 15 Apr 2021 22:14:20 +0300 Subject: [PATCH 1/2] Add the link to the issue tracking the disabled test --- src/tests/issues.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 312bba6f06cd9..3c80720278c6b 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -1042,7 +1042,7 @@ - Test not yet merged, issue will be created if the PR is to be approved + https://github.com/dotnet/runtime/issues/51323 Mono does not define out of range fp to int conversions From afeff99a99ad3edaf5e65d7491a00b9cf60badf8 Mon Sep 17 00:00:00 2001 From: SingleAccretion Date: Thu, 15 Apr 2021 22:14:43 +0300 Subject: [PATCH 2/2] Use the right method when checking for overflow --- src/coreclr/jit/gentree.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/jit/gentree.cpp b/src/coreclr/jit/gentree.cpp index 611e48fad99bd..8bfd448e43352 100644 --- a/src/coreclr/jit/gentree.cpp +++ b/src/coreclr/jit/gentree.cpp @@ -14490,7 +14490,7 @@ GenTree* Compiler::gtFoldExprConst(GenTree* tree) if (tree->gtOverflow() && ((op1->TypeIs(TYP_DOUBLE) && CheckedOps::CastFromDoubleOverflows(d1, tree->CastToType())) || (op1->TypeIs(TYP_FLOAT) && - CheckedOps::CastFromDoubleOverflows(forceCastToFloat(d1), tree->CastToType())))) + CheckedOps::CastFromFloatOverflows(forceCastToFloat(d1), tree->CastToType())))) { return tree; }