Pass along PGO type and use it in artifacts names #48171
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| - windows_x64 | ||
| jobParameters: | ||
| testGroup: innerloop | ||
| pgoType: 'PGO' |
There was a problem hiding this comment.
do we expect different PGO types or why didn't you choose a bool?
There was a problem hiding this comment.
I couldn't figure out a good way in YAML to turn a bool into a string, and didn't want to repeat a conditional in the build where I change the name of jobs to include "PGO". If you have a better way I'd love to use it. I couldn't find any support for something like if(pgoInstrument, 'PGO', '') in YAML.
There was a problem hiding this comment.
ah I see. Unfortunately there is no way in YAML to do that. So let's keep it as is.
|
@safern @jkoritzinsky Anything else? |
|
@agocke if you haven't can you trigger an official build from this branch to make sure it is not broken? |
|
@safern How do I trigger a pipeline on the branch of a fork? Wouldn't it have to be on the runtime repo itself? |
|
You can push your branch to the internal repo and manually trigger a build for your branch. |
|
Tested this in the official build and it's all green. |
ghost
locked as resolved and limited conversation to collaborators
4 participants
No description provided.