From 40134e650a0e1f8a422a760e5e302b1024f0515b Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Mon, 23 Mar 2020 03:30:17 -0700 Subject: [PATCH 1/6] Enable some tests passing locally --- src/mono/netcore/CoreFX.issues_linux.rsp | 46 ++---------------------- 1 file changed, 3 insertions(+), 43 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues_linux.rsp b/src/mono/netcore/CoreFX.issues_linux.rsp index 5cd79c59942da..6f0044b93ff87 100644 --- a/src/mono/netcore/CoreFX.issues_linux.rsp +++ b/src/mono/netcore/CoreFX.issues_linux.rsp @@ -4,46 +4,6 @@ -nomethod System.Tests.AppDomainTests.TestingCreateInstanceFromObjectHandleFullSignature -nomethod System.Tests.AppDomainTests.TestingCreateInstanceFromObjectHandle -# hangs --nomethod *.HttpClientUsesSslCertEnvironmentVariables --nomethod System.Threading.Tasks.Dataflow.Tests.DataflowBlockExtensionsTests.* - -# dllmap is not working --nonamespace System.IO.MemoryMappedFiles --nonamespace System.Diagnostics.Tests --nonamespace System.IO.Tests --nomethod System.IO.Pipes.Tests.NamedPipeTest_CreateClient.NotSupportedPipePath_Throws_PlatformNotSupportedException --nomethod System.Net.Sockets.Tests.SocketOptionNameTest.ReuseAddressUdp - --nomethod System.Tests.WeakReferenceTests.Generic --nomethod System.Reflection.Tests.AssemblyTests.CreateInstance - -# StackOverflow somewhere here --nonamespace System.Threading.Tasks.Tests - -# Requires precise GC (should be ignored in dotnet/corefx for mono) --nomethod System.Collections.Concurrent.Tests.ConcurrentQueueTests.ReferenceTypes_NulledAfterDequeue --nomethod System.Threading.Tests.ThreadLocalTests.RunThreadLocalTest7_WeakReference --nomethod System.ComponentModel.EventBasedAsync.Tests.BackgroundWorkerTests.TestFinalization - -# fails with some OpenSSL error --nomethod System.Net.Security.Tests.ServerRequireEncryptionTest.ServerRequireEncryption_ClientNoEncryption_NoConnect --nomethod System.Net.Security.Tests.SslStreamAlpnTests.SslStream_StreamToStream_Alpn_NonMatchingProtocols_Fail --nomethod System.Net.Security.Tests.ClientDefaultEncryptionTest.ClientDefaultEncryption_ServerNoEncryption_NoConnect --nomethod System.Net.Security.Tests.ServerNoEncryptionTest.ServerNoEncryption_ClientRequireEncryption_NoConnect --nomethod System.Net.Security.Tests.ClientAsyncAuthenticateTest.ClientAsyncAuthenticate_ServerNoEncryption_NoConnect --nomethod System.Net.Security.Tests.ServerAsyncAuthenticateTest.ServerAsyncAuthenticate_MismatchProtocols_Fails --nomethod System.Net.Security.Tests.ClientAsyncAuthenticateTest.ClientAsyncAuthenticate_MismatchProtocols_Fails - -# https://github.com/mono/mono/issues/18067 LLVM: try-catch doesn't catch an exception --nomethod System.Reflection.Tests.BindingFlagsDoNotWrapTests.* - -# fail on Helix on RedHat systems because libgdiplus can't be loaded --nomethod System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.RoundtripManyObjectsInOneStream --nomethod System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.ValidateBasicObjectsRoundtrip --nomethod System.Resources.Tests.ResourceManagerTests.GetObject_Images --nomethod System.Resources.Tests.ResourceManagerTests.GetObject_Images_ResourceSet --nomethod System.Resources.Tests.ResourceManagerTests.GetResourceSet_Images --nomethod System.Resources.Extensions.Tests.PreserializedResourceWriterTests.BinaryFormattedResources --nomethod System.Resources.Extensions.Tests.PreserializedResourceWriterTests.StreamResources --nomethod System.Resources.Extensions.Tests.PreserializedResourceWriterTests.BinaryFormattedResourcesWithoutTypeName +-nomethod System.Threading.Tasks.Dataflow.Tests.DataflowBlockExtensionsTests.TestReceiveAsync_LongChain +-nomethod System.Threading.Tasks.Dataflow.Tests.DataflowBlockExtensionsTests.TestOutputAvailableAsync_LongSequence +-nomethod System.Threading.Tasks.Tests.* \ No newline at end of file From 6580ee0872d54214d4731e1c4dbca3da167cadac Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 24 Mar 2020 04:30:03 -0700 Subject: [PATCH 2/6] Disable several tests failing in linux CI due to the problem with libgdiplus --- .../tests/BinaryResourceWriterUnitTest.cs | 3 +++ .../tests/ResourceManagerTests.cs | 3 +++ .../tests/BinaryFormatterTests.cs | 2 ++ 3 files changed, 8 insertions(+) diff --git a/src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs b/src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs index 085ee9be2ad18..4b7a3b8c3de55 100644 --- a/src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs +++ b/src/libraries/System.Resources.Extensions/tests/BinaryResourceWriterUnitTest.cs @@ -264,6 +264,7 @@ public static void PrimitiveResourcesAsStrings() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] public static void BinaryFormattedResources() { var values = TestData.BinaryFormatted; @@ -300,6 +301,7 @@ public static void BinaryFormattedResources() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] public static void BinaryFormattedResourcesWithoutTypeName() { var values = TestData.BinaryFormatted; @@ -397,6 +399,7 @@ public static void TypeConverterStringResources() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] public static void StreamResources() { var values = TestData.Activator; diff --git a/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs b/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs index d2bacfe49fba1..c4e5f6ddcce45 100644 --- a/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs +++ b/src/libraries/System.Resources.ResourceManager/tests/ResourceManagerTests.cs @@ -268,6 +268,7 @@ public static IEnumerable EnglishImageResourceData() } [ConditionalTheory(Helpers.IsDrawingSupported)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [MemberData(nameof(EnglishImageResourceData))] public static void GetObject_Images(string key, object expectedValue) { @@ -277,6 +278,7 @@ public static void GetObject_Images(string key, object expectedValue) } [ConditionalTheory(Helpers.IsDrawingSupported)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [MemberData(nameof(EnglishImageResourceData))] public static void GetObject_Images_ResourceSet(string key, object expectedValue) { @@ -310,6 +312,7 @@ public static void GetResourceSet_NonStrings(string key, object expectedValue, b } [ConditionalTheory(Helpers.IsDrawingSupported)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [MemberData(nameof(EnglishImageResourceData))] public static void GetResourceSet_Images(string key, object expectedValue) { diff --git a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs index a54bf833a74b8..8c9777b0f706a 100644 --- a/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs +++ b/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs @@ -47,6 +47,7 @@ public void SerializeHugeObjectGraphs(int limit) [Theory] [SkipOnCoreClr("Takes too long on Checked", RuntimeConfiguration.Checked)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [MemberData(nameof(BasicObjectsRoundtrip_MemberData))] public void ValidateBasicObjectsRoundtrip(object obj, FormatterAssemblyStyle assemblyFormat, TypeFilterLevel filterLevel, FormatterTypeStyle typeFormat) { @@ -183,6 +184,7 @@ public void ValidateDeserializationOfObjectWithGenericTypeWhichGenericArgumentHa } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34008", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] public void RoundtripManyObjectsInOneStream() { object[][] objects = SerializableObjects_MemberData().ToArray(); From ae94ba7583935f118ec9d10a59f57a42454c6c67 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 24 Mar 2020 07:07:28 -0700 Subject: [PATCH 3/6] Enable tests passing locally on Ubuntu 18.04 --- src/mono/netcore/CoreFX.issues_linux.rsp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mono/netcore/CoreFX.issues_linux.rsp b/src/mono/netcore/CoreFX.issues_linux.rsp index 6f0044b93ff87..b44f4b3923386 100644 --- a/src/mono/netcore/CoreFX.issues_linux.rsp +++ b/src/mono/netcore/CoreFX.issues_linux.rsp @@ -3,7 +3,3 @@ -nomethod System.Tests.ActivatorTests.TestingCreateInstanceFromObjectHandle -nomethod System.Tests.AppDomainTests.TestingCreateInstanceFromObjectHandleFullSignature -nomethod System.Tests.AppDomainTests.TestingCreateInstanceFromObjectHandle - --nomethod System.Threading.Tasks.Dataflow.Tests.DataflowBlockExtensionsTests.TestReceiveAsync_LongChain --nomethod System.Threading.Tasks.Dataflow.Tests.DataflowBlockExtensionsTests.TestOutputAvailableAsync_LongSequence --nomethod System.Threading.Tasks.Tests.* \ No newline at end of file From 507fef43a5417d4ab054f89849c2fb42cca0674c Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 24 Mar 2020 11:42:49 -0700 Subject: [PATCH 4/6] Disable several tests failing in AssemblyLoadContext.InternalLoadFromPath --- .../tests/System/AppDomainTests.cs | 2 ++ src/libraries/System.Runtime/tests/System/ActivatorTests.cs | 2 ++ src/mono/netcore/CoreFX.issues_linux.rsp | 6 +----- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs index 7f46dc70eb87e..a8e661bafca7b 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs @@ -747,6 +747,7 @@ public static void GetPermissionSet() } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))] public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType) { @@ -846,6 +847,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string }; [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))] public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType) { diff --git a/src/libraries/System.Runtime/tests/System/ActivatorTests.cs b/src/libraries/System.Runtime/tests/System/ActivatorTests.cs index 773b80b17d3ee..5cb07283312a4 100644 --- a/src/libraries/System.Runtime/tests/System/ActivatorTests.cs +++ b/src/libraries/System.Runtime/tests/System/ActivatorTests.cs @@ -620,6 +620,7 @@ public void CreateInstance_PublicOnlyValueTypeWithPrivateDefaultConstructor_Thro } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))] public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType) { @@ -717,6 +718,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string }; [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))] public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType) { diff --git a/src/mono/netcore/CoreFX.issues_linux.rsp b/src/mono/netcore/CoreFX.issues_linux.rsp index b44f4b3923386..8b137891791fe 100644 --- a/src/mono/netcore/CoreFX.issues_linux.rsp +++ b/src/mono/netcore/CoreFX.issues_linux.rsp @@ -1,5 +1 @@ -# See TODO in AssemblyLoadContext.InternalLoadFromPath() --nomethod System.Tests.ActivatorTests.TestingCreateInstanceFromObjectHandleFullSignature --nomethod System.Tests.ActivatorTests.TestingCreateInstanceFromObjectHandle --nomethod System.Tests.AppDomainTests.TestingCreateInstanceFromObjectHandleFullSignature --nomethod System.Tests.AppDomainTests.TestingCreateInstanceFromObjectHandle + From b879312744cae7f8a6d6de9cfb9179d954e88093 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 24 Mar 2020 22:08:33 -0700 Subject: [PATCH 5/6] Remove CoreFX.issues_linux.rsp file --- eng/testing/tests.targets | 3 +-- src/mono/netcore/CoreFX.issues_linux.rsp | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) delete mode 100644 src/mono/netcore/CoreFX.issues_linux.rsp diff --git a/eng/testing/tests.targets b/eng/testing/tests.targets index c895afbb27832..00ae17dc1ab3e 100644 --- a/eng/testing/tests.targets +++ b/eng/testing/tests.targets @@ -80,11 +80,10 @@ <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" /> - <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" /> <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" /> - <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX'" /> + <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' == 'Linux'" /> diff --git a/src/mono/netcore/CoreFX.issues_linux.rsp b/src/mono/netcore/CoreFX.issues_linux.rsp deleted file mode 100644 index 8b137891791fe..0000000000000 --- a/src/mono/netcore/CoreFX.issues_linux.rsp +++ /dev/null @@ -1 +0,0 @@ - From 84984d50726584c810b5be8b65f6ddcfbc81b0c4 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 24 Mar 2020 22:11:22 -0700 Subject: [PATCH 6/6] Fix condition for including rsp files --- eng/testing/tests.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/testing/tests.targets b/eng/testing/tests.targets index 00ae17dc1ab3e..ad930a6e74487 100644 --- a/eng/testing/tests.targets +++ b/eng/testing/tests.targets @@ -83,7 +83,7 @@ <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" /> - <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' == 'Linux'" /> + <_rspFileContent Include="$([System.IO.File]::ReadAllText(%(_rspFile.Identity)))" Condition="'$(TargetOS)' != 'OSX' and '$(TargetOS)' != 'Linux'" />