Skip to content

Conversation

@kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Nov 26, 2025

Description

Crossgen2 is currently compiling for maccatalyst 15.2 but linking against 15.0. This change ensures that R2R object file is built and linked against the same version on maccatalyst.

Error log:

##[error]ld(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) object file (/Users/runner/work/1/s/artifacts/obj/coreclr/crossgen-corelib/maccatalyst.x64.Release/System.Private.CoreLib.o) was built for newer 'macCatalyst' version (15.2) than being linked (15.0)

Copilot AI review requested due to automatic review settings November 26, 2025 23:45
@kotlarmilos kotlarmilos added the os-ios Apple iOS label Nov 26, 2025
@kotlarmilos kotlarmilos added this to the 11.0.0 milestone Nov 26, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Copilot finished reviewing on behalf of kotlarmilos November 26, 2025 23:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the minimum maccatalyst version from 15.0 to 15.2 for crossgen2 and corelib builds to align the linking version with the compilation version.

  • Updated AppleMinOSVersion property for maccatalyst from 15.0 to 15.2 in crossgen2 targets
  • Updated AppleMinOSVersion property for maccatalyst from 15.0 to 15.2 in crossgen-corelib project

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets Updates maccatalyst minimum OS version to 15.2 for crossgen2 R2R compilation
src/coreclr/crossgen-corelib.proj Updates maccatalyst minimum OS version to 15.2 for corelib crossgen compilation

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

<PropertyGroup>
<AppleMinOSVersion Condition="'$(AppleMinOSVersion)' == '' and '$(_AppleTargetOS)' == 'osx'">12.0</AppleMinOSVersion>
<AppleMinOSVersion Condition="'$(AppleMinOSVersion)' == '' and '$(_AppleTargetOS)' == 'maccatalyst'">15.0</AppleMinOSVersion>
<AppleMinOSVersion Condition="'$(AppleMinOSVersion)' == '' and '$(_AppleTargetOS)' == 'maccatalyst'">15.2</AppleMinOSVersion>
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maccatalyst minimum version is being updated to 15.2 in this file, but the same version in src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets at line 81 is still set to 15.0. For consistency, that file should also be updated to 15.2 to ensure NativeAOT builds use the same minimum version.

Copilot uses AI. Check for mistakes.
@kotlarmilos
Copy link
Member Author

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant