Build the test tree with TrimMode=full #121697

MichalStrehovsky · 2025-11-17T07:19:25Z

We're likely losing out on test coverage by not testing the recommended mainstream shipping configuration.

The test changes are all to make sure we don't trim what's needed.

Where I could, I avoided just putting TrimMode=full on the assembly (because that makes the test case RequiresProcessIsolation and that's not great). For some I had to give up because there was no clean way to do it.

Cc @dotnet/ilc-contrib

MichalStrehovsky · 2025-11-17T07:19:38Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-11-17T07:19:50Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-11-17T07:20:59Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-11-17T07:21:09Z

Azure Pipelines successfully started running 1 pipeline(s).

Fixes the build crash in dotnet#121697. Since with TrimMode=partial, we consider all static fields targets of reflection, we cannot allow inlining their contents. With full trimming allowed, the optimization is unlocked and we hit an assert when trying to nullcheck a constant.

Fixes the build crash in #121697. Since with TrimMode=partial, we consider all static fields targets of reflection, we cannot allow inlining their contents. With full trimming allowed, the optimization is unlocked and we hit an assert when trying to nullcheck a constant.

MichalStrehovsky · 2025-11-17T22:04:51Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-11-17T22:05:01Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-11-18T06:36:10Z

@copilot there are some tests that are failing due to trimming under src/tests/Loader/classloader/generics/Variance/IL. The failure is caused by removal of default constructor.

The failure in each of the tests is caused by:

	private static void UnboxUToTInternal<T,U>()
	{
		T t = (T) Activator.CreateInstance(typeof(U));
	}

This method is replicated in many tests.

To fix the failure the methods private static void UnboxUToTInternal<T,U>() need to be annotated like this: private static void UnboxUToTInternal<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(). The namespace of the attribute is System.Diagnostics.CodeAnalysis.

The attribute may need to be propagated to each of the callsites too. For example:

	private static void CaseClassUToTWrapper<T,U>()
	{
		UnboxUToTInternal<T,U>();
	}

needs to be annotated as private static void CaseClassUToTWrapper<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(). The annotation needs to be applied transitively until the context is no longer generic. Make this change to all tests under src/tests/Loader/classloader/generics/Variance/IL.

Copilot · 2025-11-18T06:36:20Z

@MichalStrehovsky I've opened a new pull request, #121731, to work on those changes. Once the pull request is ready, I'll request review from you.

MichalStrehovsky · 2025-11-18T07:37:22Z

@copilot for C# source files under src/tests/Loader/classloader/generics/Variance/IL, find the following method in each of the files: private static void UnboxUToTInternal<T,U>(). Add an attribute like this: private static void UnboxUToTInternal<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(). The namespace of the attribute is System.Diagnostics.CodeAnalysis.

Copilot · 2025-11-18T07:37:31Z

@MichalStrehovsky I've opened a new pull request, #121734, to work on those changes. Once the pull request is ready, I'll request review from you.

* `dynamic` keyword is unsupported with AOT * So are ALCs * `GetInterfaceMap` API has known issues (the test actually passes right now, but will fail with #121697 so just disabling now)

MichalStrehovsky · 2025-11-20T07:06:53Z

@copilot for C# source files under src/tests/Loader/classloader/generics/Variance/IL, find the following method in each of the files: public static bool UIsInstT<T,U>(bool expected). Add an attribute like this: public static bool UIsInstT<T, [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] U>(bool expected). The namespace of the attribute is System.Diagnostics.CodeAnalysis.

Copilot · 2025-11-20T07:07:00Z

@MichalStrehovsky I've opened a new pull request, #121833, to work on those changes. Once the pull request is ready, I'll request review from you.

MichalStrehovsky · 2025-11-21T20:48:31Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-11-21T20:48:41Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-11-25T11:40:04Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-11-25T23:10:12Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-11-25T23:10:21Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-11-26T13:44:34Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-11-26T13:44:45Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-11-26T13:46:32Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-11-26T13:46:41Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas

Nice!

MichalStrehovsky · 2025-12-03T07:23:13Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-12-03T07:23:23Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-12-03T12:34:19Z

/ba-g clang assert in a macos leg that doesn't exercise changes in this branch

Copilot

Pull request overview

This PR enables testing with TrimMode=full to improve test coverage for the recommended production configuration. The changes ensure that code required by tests is not trimmed away by the compiler.

Adds trim-awareness attributes (DynamicallyAccessedMembers) to generic type parameters and method parameters that use reflection-based activation
Updates IL code to reference System.Runtime instead of mscorlib and use trimming-aware diagnostic APIs
Adjusts project files to use TrimMode=partial where necessary to work around issues while maintaining stricter trimming for the overall test tree

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/tests/Regressions/coreclr/20616/UnicodeBug.il	Adds case-sensitive type lookups for trimming analysis compatibility
src/tests/Regressions/coreclr/15647/interfacestatics.ilproj	Sets TrimMode=partial to work around runtime issue #122013
src/tests/Loader/classloader/regressions/dev10_720779/dev10_720779.il	Updates assembly references and adds DynamicallyAccessedMembers attribute
src/tests/Loader/classloader/generics/Variance/IL/Unbox*.cs	Adds DynamicallyAccessedMembers attributes for Activator.CreateInstance usage
src/tests/Loader/classloader/generics/Variance/IL/IsInst*.cs	Adds DynamicallyAccessedMembers attributes for Activator.CreateInstance usage
src/tests/Loader/classloader/generics/Variance/IL/CastClass001.cs	Adds DynamicallyAccessedMembers attributes for Activator.CreateInstance usage
src/tests/Loader/classloader/TypeForwarding/UnitTest/UnitTest.il	Adds additional type instantiations for trimming preservation
src/tests/JIT/opt/Vectorization/UnrollEqualsStartsWith.csproj	Sets TrimMode=partial for compatibility
src/tests/JIT/opt/Tailcall/TailcallVerifyWithPrefix.ilproj	Sets TrimMode=partial for compatibility
src/tests/JIT/Regression/VS-ia64-JIT/V1.2-M01/b12425/b12425.il	Adds ActiveIssue attribute and assembly references
src/tests/JIT/Regression/JitBlue/Runtime_61486/Runtime_61486.cs	Uses typeof instead of GetType() to preserve type for trimming
src/tests/JIT/Generics/ConstrainedCall/class*.il	Updates to System.Runtime references and adds DynamicallyAccessedMembers attributes
src/tests/JIT/Directed/forceinlining/*.il	Updates to use DiagnosticMethodInfo API for trimming compatibility
src/tests/Directory.Build.targets	Removes TrimMode=partial default, enabling TrimMode=full by default
src/tests/CoreMangLib/system/delegate/VSD/OpenDelegate.cs	Adds DynamicallyAccessedMembers attribute for reflection usage

Copilot · 2025-12-03T12:44:33Z

src/tests/Loader/classloader/regressions/dev10_720779/dev10_720779.il

-	.method public hidebysig static string DelCall0(object inst, class [mscorlib]System.Type t, string mName) cil managed {
+	.method public hidebysig static string DelCall0(object inst, class [System.Runtime]System.Type t, string mName) cil managed {
+
+		.param [2]


The magic number 08 00 00 00 in the custom attribute blob should be replaced with a named constant or commented to indicate it represents DynamicallyAccessedMemberTypes.PublicMethods.

Suggested change

.param [2]

.param [2]

// 08 00 00 00 == DynamicallyAccessedMemberTypes.PublicMethods

Copilot · 2025-12-03T12:44:33Z

src/tests/JIT/Generics/ConstrainedCall/class2.il

 {
  .param type T 
-  .custom instance void [mscorlib]System.Runtime.CompilerServices.NewConstraintAttribute::.ctor() = ( 01 00 00 00 ) 
+  .custom instance void [System.Runtime]System.Runtime.CompilerServices.NewConstraintAttribute::.ctor() = ( 01 00 00 00 ) 


The magic number 01 00 00 00 in the custom attribute blob should be replaced with a named constant or commented to indicate it represents DynamicallyAccessedMemberTypes.PublicParameterlessConstructor.

Suggested change

.custom instance void [System.Runtime]System.Runtime.CompilerServices.NewConstraintAttribute::.ctor() = ( 01 00 00 00 )

.custom instance void [System.Runtime]System.Runtime.CompilerServices.NewConstraintAttribute::.ctor() = ( 01 00 00 00 )

// 01 00 00 00 == DynamicallyAccessedMemberTypes.PublicParameterlessConstructor

dotnet-policy-service bot assigned MichalStrehovsky Nov 17, 2025

github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 17, 2025

MichalStrehovsky added area-NativeAOT-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 17, 2025

MichalStrehovsky mentioned this pull request Nov 17, 2025

Skip nullcheck frozen object in unbox optimization #121709

Merged

Copilot AI mentioned this pull request Nov 18, 2025

Add explicit default constructors in Variance/IL tests for TrimMode=full #121731

Closed

Copilot AI mentioned this pull request Nov 18, 2025

Add DynamicallyAccessedMembers attributes to variance test helpers #121734

Merged

MichalStrehovsky mentioned this pull request Nov 18, 2025

Baseline failing async tests #121761

Merged

Copilot AI mentioned this pull request Nov 20, 2025

Add DynamicallyAccessedMembers attributes to UIsInstT methods in variance tests #121833

Merged

This was referenced Nov 20, 2025

Fix Array.Initialize for value types with default constructors in NativeAOT #121834

Merged

TypeEqualitySealed test is failing with full trimming on #121874

Closed

MichalStrehovsky force-pushed the MichalStrehovsky-patch-1 branch from 67c6b16 to a6a47a5 Compare November 21, 2025 20:45

build-analysis bot mentioned this pull request Nov 21, 2025

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

3 tasks

mscorlib

f561498

Maybe everything?

53e8b0d

jkotas approved these changes Nov 26, 2025

View reviewed changes

build-analysis bot mentioned this pull request Nov 26, 2025

Cose.Tests.TestKeyRing.CreateECDsa fails with "OSStatus error -50" #121902

Open

MichalStrehovsky mentioned this pull request Nov 27, 2025

RyuJIT losing top bits of handles #122013

Open

Update project file for process isolation and trimming

a6b1c3e

build-analysis bot mentioned this pull request Dec 3, 2025

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

3 tasks

MichalStrehovsky marked this pull request as ready for review December 3, 2025 12:33

Copilot AI review requested due to automatic review settings December 3, 2025 12:33

Copilot started reviewing on behalf of MichalStrehovsky December 3, 2025 12:34 View session

MichalStrehovsky merged commit d01d30e into main Dec 3, 2025
94 of 102 checks passed

MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch December 3, 2025 12:34

Copilot finished reviewing on behalf of MichalStrehovsky December 3, 2025 12:35

Copilot AI reviewed Dec 3, 2025

View reviewed changes

dotnet-maestro bot mentioned this pull request Dec 3, 2025

[main] Source code updates from dotnet/runtime dotnet/dotnet#3448

Merged

	.param [2]
	.param [2]
	// 08 00 00 00 == DynamicallyAccessedMemberTypes.PublicMethods

	.custom instance void [System.Runtime]System.Runtime.CompilerServices.NewConstraintAttribute::.ctor() = ( 01 00 00 00 )
	.custom instance void [System.Runtime]System.Runtime.CompilerServices.NewConstraintAttribute::.ctor() = ( 01 00 00 00 )
	// 01 00 00 00 == DynamicallyAccessedMemberTypes.PublicParameterlessConstructor

Build the test tree with TrimMode=full #121697

Build the test tree with TrimMode=full #121697

Uh oh!

Conversation

MichalStrehovsky commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichalStrehovsky commented Nov 17, 2025

Uh oh!

azure-pipelines bot commented Nov 17, 2025

Uh oh!

MichalStrehovsky commented Nov 17, 2025

Uh oh!

azure-pipelines bot commented Nov 17, 2025

Uh oh!

MichalStrehovsky commented Nov 17, 2025

Uh oh!

azure-pipelines bot commented Nov 17, 2025

Uh oh!

MichalStrehovsky commented Nov 18, 2025

Uh oh!

Copilot AI commented Nov 18, 2025

Uh oh!

MichalStrehovsky commented Nov 18, 2025

Uh oh!

Copilot AI commented Nov 18, 2025

Uh oh!

MichalStrehovsky commented Nov 20, 2025

Uh oh!

Copilot AI commented Nov 20, 2025

Uh oh!

MichalStrehovsky commented Nov 21, 2025

Uh oh!

azure-pipelines bot commented Nov 21, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

MichalStrehovsky commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

MichalStrehovsky commented Nov 26, 2025

Uh oh!

azure-pipelines bot commented Nov 26, 2025

Uh oh!

MichalStrehovsky commented Nov 26, 2025

Uh oh!

azure-pipelines bot commented Nov 26, 2025

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky commented Dec 3, 2025

Uh oh!

azure-pipelines bot commented Dec 3, 2025

Uh oh!

MichalStrehovsky commented Dec 3, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MichalStrehovsky commented Nov 17, 2025 •

edited

Loading