Skip to content

Fix install-dependencies.sh for Amazon Linux 2023 #120466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix install-dependencies.sh for Amazon Linux 2023 #120466

wants to merge 1 commit into from

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Oct 7, 2025

install-dependencies.sh used to be no-op on Amazon Linux 2023.

also, it doesn't need curl dependency, it comes with curl-minimal preinstalled (which is mutually exclusive with just curl).

Copilot AI review requested due to automatic review settings October 7, 2025 14:21
Copilot AI reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 7, 2025
@vcsjones
Copy link
Member

vcsjones commented Oct 7, 2025

Note that things in eng/common are mirrored from arcade, so these changes belong in arcade and will eventually sync over here.

See https://github.com/dotnet/runtime/blob/main/eng/common/README.md.

@EgorBo EgorBo closed this Oct 7, 2025
@EgorBo
Copy link
Member Author

EgorBo commented Oct 7, 2025

Note that things in eng/common are mirrored from arcade, so these changes belong in arcade and will eventually sync over here.

See https://github.com/dotnet/runtime/blob/main/eng/common/README.md.

oops. didn't realize that, thanks!

@build-analysis build-analysis bot mentioned this pull request Oct 7, 2025
Open
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@EgorBo EgorBo

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo @vcsjones