From 19efb5ecda3a0fc39944bf6a219e5011d62bbcc2 Mon Sep 17 00:00:00 2001 From: xtqqczze <45661989+xtqqczze@users.noreply.github.com> Date: Wed, 17 Sep 2025 10:43:53 +0100 Subject: [PATCH] Name boolean arguments in `StreamReader` ctors Update `StreamReader` constructors to name boolean arguments for clarity. --- .../src/System/IO/StreamReader.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/IO/StreamReader.cs b/src/libraries/System.Private.CoreLib/src/System/IO/StreamReader.cs index e06a2512264c8d..5ab79f46d8e649 100644 --- a/src/libraries/System.Private.CoreLib/src/System/IO/StreamReader.cs +++ b/src/libraries/System.Private.CoreLib/src/System/IO/StreamReader.cs @@ -101,22 +101,22 @@ private StreamReader() } public StreamReader(Stream stream) - : this(stream, true) + : this(stream, detectEncodingFromByteOrderMarks: true) { } public StreamReader(Stream stream, bool detectEncodingFromByteOrderMarks) - : this(stream, Encoding.UTF8, detectEncodingFromByteOrderMarks, DefaultBufferSize, false) + : this(stream, Encoding.UTF8, detectEncodingFromByteOrderMarks, DefaultBufferSize, leaveOpen: false) { } public StreamReader(Stream stream, Encoding? encoding) - : this(stream, encoding, true, DefaultBufferSize, false) + : this(stream, encoding, detectEncodingFromByteOrderMarks: true, DefaultBufferSize, leaveOpen: false) { } public StreamReader(Stream stream, Encoding? encoding, bool detectEncodingFromByteOrderMarks) - : this(stream, encoding, detectEncodingFromByteOrderMarks, DefaultBufferSize, false) + : this(stream, encoding, detectEncodingFromByteOrderMarks, DefaultBufferSize, leaveOpen: false) { } @@ -131,7 +131,7 @@ public StreamReader(Stream stream, Encoding? encoding, bool detectEncodingFromBy // of those three match, it will use the Encoding you provided. // public StreamReader(Stream stream, Encoding? encoding, bool detectEncodingFromByteOrderMarks, int bufferSize) - : this(stream, encoding, detectEncodingFromByteOrderMarks, bufferSize, false) + : this(stream, encoding, detectEncodingFromByteOrderMarks, bufferSize, leaveOpen: false) { } @@ -177,7 +177,7 @@ public StreamReader(Stream stream, Encoding? encoding = null, bool detectEncodin } public StreamReader(string path) - : this(path, true) + : this(path, detectEncodingFromByteOrderMarks: true) { } @@ -187,7 +187,7 @@ public StreamReader(string path, bool detectEncodingFromByteOrderMarks) } public StreamReader(string path, Encoding? encoding) - : this(path, encoding, true, DefaultBufferSize) + : this(path, encoding, detectEncodingFromByteOrderMarks: true, DefaultBufferSize) { } @@ -202,7 +202,7 @@ public StreamReader(string path, Encoding? encoding, bool detectEncodingFromByte } public StreamReader(string path, FileStreamOptions options) - : this(path, Encoding.UTF8, true, options) + : this(path, Encoding.UTF8, detectEncodingFromByteOrderMarks: true, options) { }