SPMI: Enable -details for asmdiffs and tpdiff #119711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was enabled for replay, but not for asmdiffs/tpdiff. Add that support as well.
github-actions
bot
added
the
area-CodeGen-coreclr
There was a problem hiding this comment.
Pull Request Overview
This PR extends the existing -details support to the asmdiffs and tpdiff SuperPMI commands, similar to what was already available for replay. This change allows users to specify a custom path for the detailed CSV output file rather than using the default temporary location.
Key changes:
- Added support for the
-detailsoption in asmdiffs and tpdiff commands - Moved details verification from replay-specific to common argument verification
jakobbotsch
commented
Sep 15, 2025
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
PTAL @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Sep 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was enabled for replay, but not for asmdiffs/tpdiff. Add that support as well.