[release/10.0] Remove IList.Contains use from OfType #119608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
added
Servicing-consider
jkotas
approved these changes
Sep 12, 2025
artl93
approved these changes
Sep 12, 2025
|
Yup. RC2 |
|
/ba-g failure is unrelated (failure to pull a container image) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119600 to release/10.0
/cc @stephentoub
Customer Impact
Using
.OfType<T>().Contains(...)on a source that turns out to be a multidimensional array throws an exception.Regression
February
Testing
Added unit tests to cover the scenario and surrounding ones.
Risk
Low. It's reverting the relevant portion of a change made in .NET 10 that was purely an optimization.