From 55a27ab4e8baa7997cfdac9f57db63c004d1f8c3 Mon Sep 17 00:00:00 2001 From: Max Charlamb <44248479+max-charlamb@users.noreply.github.com> Date: Fri, 5 Sep 2025 12:02:37 -0400 Subject: [PATCH 1/2] properly return internal_root_array --- src/coreclr/debug/daccess/request.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/debug/daccess/request.cpp b/src/coreclr/debug/daccess/request.cpp index c6900689384220..8aa86763388a9d 100644 --- a/src/coreclr/debug/daccess/request.cpp +++ b/src/coreclr/debug/daccess/request.cpp @@ -3253,7 +3253,7 @@ ClrDataAccess::GetHeapAnalyzeStaticData(struct DacpGcHeapAnalyzeData *analyzeDat SOSDacEnter(); - analyzeData->internal_root_array = dac_cast(g_gcDacGlobals->internal_root_array); + analyzeData->internal_root_array = dac_cast(*g_gcDacGlobals->internal_root_array); analyzeData->internal_root_array_index = *g_gcDacGlobals->internal_root_array_index; analyzeData->heap_analyze_success = *g_gcDacGlobals->heap_analyze_success; From c2a9b8265161e403acdb28c1290a21e4398da6ba Mon Sep 17 00:00:00 2001 From: Max Charlamb <44248479+max-charlamb@users.noreply.github.com> Date: Mon, 8 Sep 2025 16:32:40 -0400 Subject: [PATCH 2/2] fix dereference --- src/coreclr/debug/daccess/request.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/debug/daccess/request.cpp b/src/coreclr/debug/daccess/request.cpp index 8aa86763388a9d..ad10b3be7b5cae 100644 --- a/src/coreclr/debug/daccess/request.cpp +++ b/src/coreclr/debug/daccess/request.cpp @@ -3253,7 +3253,7 @@ ClrDataAccess::GetHeapAnalyzeStaticData(struct DacpGcHeapAnalyzeData *analyzeDat SOSDacEnter(); - analyzeData->internal_root_array = dac_cast(*g_gcDacGlobals->internal_root_array); + analyzeData->internal_root_array = TO_CDADDR((TADDR)(*g_gcDacGlobals->internal_root_array)); analyzeData->internal_root_array_index = *g_gcDacGlobals->internal_root_array_index; analyzeData->heap_analyze_success = *g_gcDacGlobals->heap_analyze_success;