-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[clr-interp] Enable CoreCLR interpreter functional test on iOS and MacCatalyst #119177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clr-interp] Enable CoreCLR interpreter functional test on iOS and MacCatalyst #119177
Conversation
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp list |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
/azp run runtime-ioslike |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This PR is ready for review. The new jobs are:
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
| /// R2R | ||
| /// | ||
| RETAIL_CONFIG_STRING_INFO(INTERNAL_NativeImageSearchPaths, W("NativeImageSearchPaths"), "Extra search paths for native composite R2R images") | ||
| #if defined(TARGET_IOS) || defined(TARGET_TVOS) || defined(TARGET_MACCATALYST) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MACCATALIST isn't mobile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a different feature in the build system, but it is treated the same as mobile where JIT is not allowed.
Description
This PR enables the CoreCLR interpreter functional test on iOS and MacCatalyst. It updates the build system to support cached interface dispatch to avoid RWX pages and updates the executable allocator to use RW pages instead of RWX. R2R is disabled by default when the interpreter is used.
Changes
Out of scope / Follow-up
Fixes #118647