-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add NativeAOT on Android tests for Globalization, Interop, and Cryptography #118651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't use BundleDir for android bundle dir: This is PublishDir when TestSingleFile=true (which it is). Android deletes this dir before packaging, deleting the files that were just published. - Don't add the singleFileTestRunner.cs when the test sets IsFunctionalTest=true - Don't run regular nativeaot smoke tests on android yet. - Enable android tests to publish as libs when TestSingleFile=true (default when TestNativeAOT=true)
…/runtime into AndroidAppBuilderNaot
…/runtime into AndroidAppBuilderNaot
jkotas
reviewed
Aug 12, 2025
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Outdated
Show resolved
Hide resolved
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infra changes lgtm!
jkotas
reviewed
Aug 12, 2025
src/libraries/System.Security.Cryptography/tests/Rfc2898OneShotTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 12, 2025
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
approved these changes
Sep 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run System.Globalization.Tests, System.Security.Cryptography.Tests.csproj, and System.Runtime.InteropServices.Tests on Android with NativeAOT.
Add shared msbuild logic for running NativeAOT on Android.