Skip to content

[cDAC] X86 support FuncEvalFrame #116796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

[cDAC] X86 support FuncEvalFrame #116796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions ...nostics.DataContractReader.Contracts/Contracts/StackWalk/FrameHandling/X86FrameHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ internal class X86FrameHandler(Target target, ContextHolder<X86Context> contextH
{
private readonly ContextHolder<X86Context> _context = contextHolder;

void IPlatformFrameHandler.HandleFaultingExceptionFrame(FaultingExceptionFrame frame)

public void HandleFaultingExceptionFrame(FaultingExceptionFrame frame)
{
if (frame.TargetContext is not TargetPointer targetContext)
{
Expand All @@ -24,9 +25,34 @@ void IPlatformFrameHandler.HandleFaultingExceptionFrame(FaultingExceptionFrame f
_context.Context.ContextFlags &= ~(uint)(ContextFlagsValues.CONTEXT_XSTATE & ContextFlagsValues.CONTEXT_AREA_MASK);
}

void IPlatformFrameHandler.HandleHijackFrame(HijackFrame frame)
public void HandleHijackFrame(HijackFrame frame)
{
// TODO(cdacX86): Implement handling for HijackFrame
throw new NotImplementedException();
}

public override void HandleFuncEvalFrame(FuncEvalFrame funcEvalFrame)
{
Data.DebuggerEval debuggerEval = _target.ProcessedData.GetOrAdd<Data.DebuggerEval>(funcEvalFrame.DebuggerEvalPtr);

// No context to update if we're doing a func eval from within exception processing.
if (debuggerEval.EvalDuringException)
{
return;
}

// Unlike other platforms, X86 doesn't copy the entire context
ContextHolder<X86Context> evalContext = new ContextHolder<X86Context>();
evalContext.ReadFromAddress(_target, debuggerEval.TargetContext);

_context.Context.Edi = evalContext.Context.Edi;
_context.Context.Esi = evalContext.Context.Esi;
_context.Context.Ebx = evalContext.Context.Ebx;
_context.Context.Edx = evalContext.Context.Edx;
_context.Context.Ecx = evalContext.Context.Ecx;
_context.Context.Eax = evalContext.Context.Eax;
_context.Context.Ebp = evalContext.Context.Ebp;
_context.Context.Eip = evalContext.Context.Eip;
_context.Context.Esp = evalContext.Context.Esp;
}
}
Loading