Disable CoreCLR interpreter test for JIT stress #116219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a problem in the interpreter when handling calls to code that doesn't have native code yet, but that has precode already. The call to MethodDesc::PrepareInitialCode triggers an assert down its call chain due to the prestub existence. This change disables running the interpreter test with JIT stress until the problem is solved.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables the CoreCLR interpreter test for JIT stress due to an issue with generating interpreter bytecode for methods that already have a prestub.
- Updated the InterpreterTester.csproj file to include a new property that disables the test under JIT stress.
- Added a comment explaining the temporary disablement and linking to the corresponding runtime issue.
Comments suppressed due to low confidence (1)
src/tests/JIT/interpreter/InterpreterTester.csproj:11
- [nitpick] The property name 'JitOptimizationSensitive' might be ambiguous as it does not clearly indicate that the interpreter test is being disabled under JIT stress. Consider renaming it to something like 'DisableInterpreterTestUnderJitStress' for improved clarity.
<JitOptimizationSensitive>true</JitOptimizationSensitive>
Contributor
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
jakobbotsch
approved these changes
Jun 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem in the interpreter when handling calls to code that doesn't have native code yet, but that has precode already. The call to MethodDesc::PrepareInitialCode triggers an assert down its call chain due to the prestub existence.
This change disables running the interpreter test with JIT stress until the problem is solved.