Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Mar 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings March 18, 2025 01:19
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a test file that has been deemed unnecessary.

  • Removed the entire test file.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas requested a review from EgorBo March 18, 2025 01:22
@jkotas jkotas changed the title Delete useless test Delete useless tests Mar 18, 2025
@jkotas
Copy link
Member Author

jkotas commented Mar 18, 2025

Extracted from #111335. We have a plenty of coverage for this under libraries.

@am11
Copy link
Member

am11 commented Mar 18, 2025

These two apparently failed a few times in past: https://github.com/search?q=repo:dotnet/runtime+b15307+OR+b04914&type=issues, there are others which have never reported failed since the initial port (e.g. under JitBlue among other places).

@jkotas
Copy link
Member Author

jkotas commented Mar 18, 2025

These two apparently failed a few times in past

These are among the few tests under src/tests that exercise System.Globalization APIs. They are likely to fail when System.Globalization APIs are broken. We have a plenty of tests that cover System.Globalization APIs under libraries, and we prefer API tests to be under libraries in general.

@jkotas
Copy link
Member Author

jkotas commented Mar 18, 2025

there are others which have never reported failed since the initial port (e.g. under JitBlue among other places).

I assume that vast majority of tests never failed (in main). It does not mean that it is ok to delete them. The question to ask when deleting tests is whether the coverage is redundant.

@am11
Copy link
Member

am11 commented Mar 18, 2025

True, but the ones which have reportedly failed slipped though the cracks. Maybe it hasn't happened since the monorepo convergence because of live testing, so they are covered.

@jkotas
Copy link
Member Author

jkotas commented Mar 19, 2025

/ba-g unrelated timeouts

@jkotas jkotas merged commit 289c443 into dotnet:main Mar 19, 2025
67 of 72 checks passed
@jkotas jkotas deleted the b15307 branch March 19, 2025 03:09
@ophura

This comment was marked as spam.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants