Skip to content

JIT: Fix bad constant folding of (0 shift x) => x #113493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

JIT: Fix bad constant folding of (0 shift x) => x #113493

merged 1 commit into from
Mar 14, 2025

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Mar 13, 2025 •
edited
Loading

Fix #113487

Copilot AI review requested due to automatic review settings March 13, 2025 20:07
Copilot AI reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 13, 2025
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Mar 13, 2025

cc @dotnet/jit-contrib PTAL @EgorBo

No diffs

@build-analysis build-analysis bot mentioned this pull request Mar 14, 2025
Open
3 tasks
@jakobbotsch jakobbotsch merged commit e4da0a1 into dotnet:main Mar 14, 2025
114 checks passed
@jakobbotsch jakobbotsch deleted the fix-113488 branch March 14, 2025 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@EgorBo EgorBo EgorBo approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT: Bad result with shifts on arm32/x86

2 participants

@jakobbotsch @EgorBo