Added in non-generic interfaces for Tensors #113401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Note regarding the |
1 similar comment
|
Note regarding the |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces non-generic tensor interfaces and updates tensor implementations to support basic operations such as index access via object indexers, memory pinning, and filling using object values. Key changes include:
- Replacing the generic IReadOnlyTensor<TSelf, T> with a non-generic IReadOnlyTensor interface.
- Introducing object-based indexers and methods for pinning backing memory.
- Updating tests to cover the new object API and memory pinning functionality.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/IReadOnlyTensor.cs | Replaces the generic interface with a non-generic version and adds new properties/methods (Lengths, Strides, indexers, GetPinnedHandle). |
| src/libraries/System.Numerics.Tensors/tests/TensorTests.cs | Adds new tests for object-based filling, index access, and pinned memory handling. |
| src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/ITensor.cs | Updates the ITensor interface to inherit from the non-generic IReadOnlyTensor and includes new signatures for indexers and Fill. |
| src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.cs | Adjusts the Tensor implementation to support the new non-generic interfaces and implements the GetPinnedHandle and object-based Fill methods. |
| src/libraries/System.Numerics.Tensors/ref/System.Numerics.Tensors.netcore.cs | Updates the reference assemblies to reflect changes in the interfaces and class signatures. |
This was referenced Mar 12, 2025
src/libraries/System.Numerics.Tensors/ref/System.Numerics.Tensors.netcore.cs
Show resolved
Hide resolved
src/libraries/System.Numerics.Tensors/ref/System.Numerics.Tensors.netcore.cs
Show resolved
Hide resolved
| /// <summary> | ||
| /// Pins and gets a <see cref="MemoryHandle"/> to the backing memory. | ||
| /// </summary> | ||
| /// <returns><see cref="MemoryHandle"/></returns> |
tarekgh
reviewed
Mar 12, 2025
src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.cs
Show resolved
Hide resolved
tarekgh
approved these changes
Mar 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111968 and fixes #111966
Addes in gon-generic interfaces for tensors that let you do basic operations.
Also adds in the ability to pin the backing memory.