Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][hybrid] drop wrap_error_root,wrap_no_error_root #98365

Closed
Tracked by #85592
pavelsavara opened this issue Feb 13, 2024 · 2 comments · Fixed by #101390
Closed
Tracked by #85592

[browser][hybrid] drop wrap_error_root,wrap_no_error_root #98365

pavelsavara opened this issue Feb 13, 2024 · 2 comments · Fixed by #101390
Assignees
@ilonatommy
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Milestone
9.0.0

Comments

@pavelsavara
Copy link
Member

pavelsavara commented Feb 13, 2024 •
edited
Loading

drop wrap_error_root and wrap_no_error_root
replace it with UTF8 char* of the error, no GC boundary breached.

It is only used in ST in mono_wasm_bind_js_import and in hybrid.
Hybrid globalization uses MonoString* heavily so it's not MT friendly anyway.
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Feb 13, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Feb 13, 2024
@pavelsavara pavelsavara self-assigned this Feb 13, 2024
@ghost
Copy link

ghost commented Feb 13, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

drop wrap_error_root and wrap_no_error_root
replace it with UTF8 char* of the error, no GC boundary breached.

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

This was referenced Feb 13, 2024
Closed
Open
@pavelsavara
Copy link
Member Author

cc @ilonatommy

@pavelsavara pavelsavara changed the title [browser][MT] drop wrap_error_root,wrap_no_error_root [browser][hybrid] drop wrap_error_root,wrap_no_error_root Mar 25, 2024
@pavelsavara pavelsavara mentioned this issue Mar 25, 2024
Merged
@ilonatommy ilonatommy mentioned this issue Apr 4, 2024
Closed
@ilonatommy ilonatommy mentioned this issue Apr 22, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Apr 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript in-pr There is an active PR which will close this issue when it is merged os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

[browser][hybrid] drop wrap_error_root, wrap_no_error_root ilonatommy/runtime
2 participants
@pavelsavara @ilonatommy