-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libs][iOS] AdvSimdEncode hits PlatformNotSupportedException #96828
Comments
@vargaz, @fanyang-mono - do you know what is needed on mono side? We did that previously for Store APIs in https://github.com/dotnet/runtime/pull/93223/files#diff-012b47a27abc5dbc9d2a0b6fdef4adec27fa207a7d2b53823a8bc80f6539f5af. Probably need similar changes for Load APIs? |
Would suggest adding an ifdef MONO around that code until this is fixed. |
There is not software fallback codepath for |
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics Issue DetailsDescriptionAfter #95513 was merged, some tests that eventually invoke runtime/src/libraries/System.Collections/tests/Generic/PriorityQueue/PriorityQueue.PropertyTests.cs Line 19 in 31fa079
PlatformNotSupportedException on iOS/tvOS arm64 lanes.
It looks like Reproduction StepsOn OSX with an iOS device ./build.sh -s mono+libs -os ios -arch arm64 -c debug
./dotnet.sh build src/libraries/System.Collections/tests/System.Collections.Tests.csproj /t:Test /p:TargetOS=ios /p:TargetArchitecture=arm64 /p:Configuration=Debug /p:DevTeamProvisioning=<dev team provisioning ID> /p:XunitMethodName=System.Collections.Tests.PriorityQueue_PropertyTests.HeapSort_Heapify_String /p:MonoEnableLLVM=true /p:RunAOTCompilation=true Expected behaviorTest doesn't fail with PlatformNotSupportedException Actual behaviorVarious tests eventually that end up calling Regression?Yes Known WorkaroundsNo-op ConfigurationNo response Other informationNo response
|
Should we create an issue to implement these or is it already captured somewhere? |
@kunalspathak I've created one to track that work. #93081 |
With #93081 open, is there anything more to do on this issue or can it be closed? |
@lambdageek will run this test locally to see if it is passing now. If so, we could close this issue. Since #93081 has been completed. Thanks, @lambdageek |
@lambdageek, were you able to complete the testing? I did some basic testing locally and it looked to be working as expected |
Going to close this as the local validation shows its no longer an issue and I don't see failures in recent CI runs. Please reopen if the issue repros anywhere else. |
Description
After #95513 was merged, some tests that eventually invoke
EncodeToUtf8
such asruntime/src/libraries/System.Collections/tests/Generic/PriorityQueue/PriorityQueue.PropertyTests.cs
Line 19 in 31fa079
PlatformNotSupportedException
on iOS/tvOS arm64 lanes.It looks like
LoadVector128x3AndUnzip
is possibly the culprit, as #84510 doesn't seem to account for mono.Reproduction Steps
On OSX with an iOS device
Expected behavior
Test doesn't fail with PlatformNotSupportedException
Actual behavior
Various tests eventually that end up calling
AdvSimd.Arm64.LoadVector128x3AndUnzip
on iOS/tvOS fail withPlatformNotSupportedException
Regression?
Yes
Known Workarounds
No-op
AdvSimdEncode
on monoConfiguration
No response
Other information
No response
The text was updated successfully, but these errors were encountered: