Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the Microsoft.CodeAnalysis.* version to use compiler interceptors for source gen #90849

Closed
layomia opened this issue Aug 19, 2023 · 3 comments · Fixed by #91006
Closed

Upgrade the Microsoft.CodeAnalysis.* version to use compiler interceptors for source gen #90849

layomia opened this issue Aug 19, 2023 · 3 comments · Fixed by #91006
Assignees
@layomia
Labels
area-Extensions-Configuration blocking-release source-generator Indicates an issue with a source generator feature
Milestone
8.0.0

Comments

@layomia
Copy link
Contributor

layomia commented Aug 19, 2023 •
edited
Loading

The RC 1 PR to use interceptors in the config binding generator #90835 upgraded the version MS.CodeAnalysis.* versions for the project alone, effectively from 4.5.0 -> 4.7.0-3.23314.3. We should update the version across the entire repo to avoid source-build prebuilt issues.
@layomia layomia added area-Extensions-Configuration source-generator Indicates an issue with a source generator feature labels Aug 19, 2023
@layomia layomia added this to the 8.0.0 milestone Aug 19, 2023
@layomia layomia self-assigned this Aug 19, 2023
@ghost
Copy link

ghost commented Aug 19, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

The RC 1 PR to use interceptors in the config binding generator #90835 upgraded the version MS.CodeAnalysis.* versions for the project alone, effectively from 4.5.0 -> 4.7.0-3.23314.3. We should update the version across the entire repo to avoid source-build prebuilt issues.

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration, source-generator
Milestone: 8.0.0

@layomia
Copy link
Contributor Author

layomia commented Aug 19, 2023

cc @ericstj @MichaelSimons @ViktorHofer.

@jkoritzinsky
Copy link
Member

We can upgrade the repo across-the-board to a stable 4.7.0 release as VS 17.7 has released to the public.

@layomia layomia mentioned this issue Aug 23, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 23, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-Extensions-Configuration blocking-release source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Upgrade MicrosoftCodeAnalysisVersion_LatestVS version to 4.7.0 layomia/dotnet_runtime
2 participants
@jkoritzinsky @layomia