Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] System.Globalization.** performance regressions in Mono AOT x64 microbenchmarks from Preview 5 to Preview 7 #89250

Closed
kotlarmilos opened this issue Jul 20, 2023 · 4 comments
Labels
Milestone

Comments

@kotlarmilos
Copy link
Member

Description

The following performance regressions occurred between the Preview 4 snapshot (May 2nd, 2023) and Preview 7 snapshot (July 19th, 2023).

The configuration used for the benchmarks is Mono AOT with LLVM on x64 ubuntu 18.04.

Name Baseline Value Compare Value % Difference
System.Globalization.Tests.StringSearch.LastIndexOf_Word_NotFound(Options: (en-US, Ordinal, False)) 232.74 522.51 124.5
@kotlarmilos
Copy link
Member Author

@mkhamoyan @ilonatommy We are trying to narrow down changes between May 2nd, 2023 and July 19th, 2023 that may have caused the regressions. If you are aware of any changes that might have potentially caused these regressions, please let us know.

@mkhamoyan
Copy link
Contributor

This can be related to HybridGlobalization changes but what is surprising for me that platform is x64 ubuntu.
HybridGlobalization mode is supported on iOS/tvOS/MacCatalyst/Browser platforms. Can you give more details related to calculations?

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Jul 24, 2023

Sorry for the late reply. Your changes shouldn't affected the microbenchmark since the HybridGlobalization is not enabled yet. It looks like span-related regression #89247 (comment).

@kotlarmilos kotlarmilos modified the milestones: 8.0.0, 9.0.0 Aug 8, 2023
@steveisok
Copy link
Member

Since this is about .net 8 previews, there's not much action we can take. Closing

@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants