Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TarFile.ExtractToDirectory is unable to extract tar archives with hard links. #87463

Closed
tmds opened this issue Jun 13, 2023 · 3 comments
Closed

TarFile.ExtractToDirectory is unable to extract tar archives with hard links. #87463

tmds opened this issue Jun 13, 2023 · 3 comments
Labels
area-System.IO.Compression
Milestone
Future

Comments

@tmds
Copy link
Member

tmds commented Jun 13, 2023

The implementation assumes the LinkName stored for a hard link is a path relative to the location of the link (like with a symbolic link).
However, the LinkName for a hard link is path relative to the archive extraction directory.

I've included a commit that fixes this in the PR I already had open which changes some related code: #85378.
I can move it to a separate PR if desired.

cc @dotnet/area-system-io @carlossanlop @adamsitnik
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 13, 2023
@ghost
Copy link

ghost commented Jun 13, 2023

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

The implementation assumes the LinkName stored for a hard link is a path relative to the location of the link (like with a symbolic link).
However, the LinkName for a hard link is path relative to the archive extraction directory.

I've included a commit that fixes this in the PR I already had open which changes some related code: #85378.
I can move it to a separate PR if desired.

cc @dotnet/area-system-io @carlossanlop @adamsitnik

Author: tmds
Assignees: -
Labels:

area-System.IO
Milestone: -

@ghost
Copy link

ghost commented Jun 15, 2023

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

The implementation assumes the LinkName stored for a hard link is a path relative to the location of the link (like with a symbolic link).
However, the LinkName for a hard link is path relative to the archive extraction directory.

I've included a commit that fixes this in the PR I already had open which changes some related code: #85378.
I can move it to a separate PR if desired.

cc @dotnet/area-system-io @carlossanlop @adamsitnik

Author: tmds
Assignees: -
Labels:

area-System.IO, area-System.IO.Compression, untriaged
Milestone: -

@tmds tmds removed area-System.IO untriaged New issue has not been triaged by the area owner labels Jun 15, 2023
@tmds tmds mentioned this issue Jun 21, 2023
Merged
@ViktorHofer ViktorHofer added this to the Future milestone Jun 21, 2023
@tmds
Copy link
Member Author

tmds commented Aug 22, 2023

Fixed by #85378.

@tmds tmds closed this as completed Aug 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.IO.Compression
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@tmds @ViktorHofer