Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Add too many locals check to lvaGrabTemps #8709

Open
AndyAyersMS opened this issue Aug 7, 2017 · 0 comments
Open

JIT: Add too many locals check to lvaGrabTemps #8709

AndyAyersMS opened this issue Aug 7, 2017 · 0 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Milestone
Future

Comments

@AndyAyersMS
Copy link
Member

If checking for too many locals is a good idea in lvaGrabTemp, then it is also a good idea in lvaGrabTemps. Implement the check and handle the necessary upstream fail fasts.

Or else, decide both of these are bad ideas, and get rid of the checks all together.

category:correctness
theme:inlining
skill-level:intermediate
cost:small
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@BruceForstall BruceForstall removed the JitUntriaged CLR JIT issues needing additional triage label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@msftgits @AndyAyersMS @BruceForstall