Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][perf] Remaining AOT Linux x86-64 perf issues after RuntimeHelpers.CreateSpan<T> #83330

Closed
jandupej opened this issue Mar 13, 2023 · 4 comments
Assignees
Milestone

Comments

@jandupej
Copy link
Member

This issue tracks the performance issues that were not resolved or fully resolved by introducing RuntimeHelpers.CreateSpan<T> intrinsic to Mono. These were the original regression reports:
https://github.com/dotnet/perf-autofiling-issues/issues/12060
https://github.com/dotnet/perf-autofiling-issues/issues/12054
https://github.com/dotnet/perf-autofiling-issues/issues/11780

The following benchmarks were not improved:

  • System.Tests.Perf_Int32.TryParseSpan
  • System.Tests.Perf_Char.ToUpper('A', en-US)
  • System.Tests.Perf_String.Interpolation_MultipleArgs('A', "Foo")
  • System.Collections.Tests.Perf_PriorityQueue<String, String>.Enumerate
  • System.Collections.IterateForEach<String>.ImmutableArray
  • System.Tests.Perf_Decimal.Mod
  • IfStatements.AndArray

The benchmark history from just before the regressions occurred to just after the fix can be found here Ubuntu x64 AOT

@kotlarmilos
Copy link
Member

@jandupej Do we know why they regressed or investigation is needed?

@jandupej
Copy link
Member Author

@jandupej Do we know why they regressed or investigation is needed?

I'll need to investigate.

@jandupej jandupej modified the milestones: Future, 9.0.0 Jul 12, 2023
@DrewScoggins
Copy link
Member

Also the ToString methods in this issue are regressed still.

dotnet/perf-autofiling-issues#12121

@matouskozak
Copy link
Member

These regressions has been resolved during .NET 9 development timeframe. I confirmed by manually going thru some of the regressions that the measurement returned back to original values or improved.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants