Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Regression in System.Text.Json tests with AOT #80179

Closed
radical opened this issue Jan 4, 2023 · 7 comments · Fixed by #80186
Closed

[wasm] Regression in System.Text.Json tests with AOT #80179

radical opened this issue Jan 4, 2023 · 7 comments · Fixed by #80186
Assignees
@BrzVlad
Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono test-failure
Milestone
8.0.0

Comments

@radical
Copy link
Member

radical commented Jan 4, 2023 •
edited by build-analysis bot
Loading

Rolling build:

[10:10:47] fail: [FAIL] System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream(compactData: True, type: ProjectLockJson, jsonString: "{  \"locked\": false,  \"version\": 1,  \"targets\"...)
[10:10:47] info: System.ObjectDisposedException : Cannot access a disposed object.
[10:10:47] info: Object name: 'JsonDocument'.
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.ParseJsonAsync(Boolean compactData, TestCaseType type, String jsonString, Func`2 stringDocBuilder, Func`2 bytesDocBuilder)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream(Boolean compactData, TestCaseType type, String jsonString)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)
[10:10:47] info: --- End of stack trace from previous location ---
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)

[10:10:47] fail: [FAIL] System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream(compactData: True, type: Json40KB, jsonString: "[\n  {\n    \"_id\": \"5671eb0737b18866984067ac\","...)
[10:10:47] info: Assert.Equal() Failure
[10:10:47] info:           ↓ (pos 0)
[10:10:47] info: Expected: _id, 5671eb0737b18866984067ac, index, 0, ···
[10:10:47] info: Actual:
[10:10:47] info:           ↑ (pos 0)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.ParseJsonAsync(Boolean compactData, TestCaseType type, String jsonString, Func`2 stringDocBuilder, Func`2 bytesDocBuilder)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream(Boolean compactData, TestCaseType type, String jsonString)
[10:10:47] info: --- End of stack trace from previous location ---

These failures appeared with the rolling build 20221218.2, and log.

The only commit between this, and the previous rolling build - 20221218.1 was 200a90a (#79215).
cc @BrzVlad @vargaz

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@radical radical added arch-wasm WebAssembly architecture blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-Codegen-Interpreter-mono test-failure labels Jan 4, 2023
@radical radical added this to the 8.0.0 milestone Jan 4, 2023
@ghost
Copy link

ghost commented Jan 4, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Rolling build:

[10:10:47] fail: [FAIL] System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream(compactData: True, type: ProjectLockJson, jsonString: "{  \"locked\": false,  \"version\": 1,  \"targets\"...)
[10:10:47] info: System.ObjectDisposedException : Cannot access a disposed object.
[10:10:47] info: Object name: 'JsonDocument'.
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.ParseJsonAsync(Boolean compactData, TestCaseType type, String jsonString, Func`2 stringDocBuilder, Func`2 bytesDocBuilder)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream(Boolean compactData, TestCaseType type, String jsonString)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)
[10:10:47] info: --- End of stack trace from previous location ---
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.DepthFirstAppend(StringBuilder buf, JsonElement element)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonElement element, Int32 sizeHint)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.PrintJson(JsonDocument document, Int32 sizeHint)

[10:10:47] fail: [FAIL] System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream(compactData: True, type: Json40KB, jsonString: "[\n  {\n    \"_id\": \"5671eb0737b18866984067ac\","...)
[10:10:47] info: Assert.Equal() Failure
[10:10:47] info:           ↓ (pos 0)
[10:10:47] info: Expected: _id, 5671eb0737b18866984067ac, index, 0, ···
[10:10:47] info: Actual:
[10:10:47] info:           ↑ (pos 0)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.ParseJsonAsync(Boolean compactData, TestCaseType type, String jsonString, Func`2 stringDocBuilder, Func`2 bytesDocBuilder)
[10:10:47] info:    at System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream(Boolean compactData, TestCaseType type, String jsonString)
[10:10:47] info: --- End of stack trace from previous location ---

These failures appeared with the rolling build 20221218.2, and log.

The only commit between this, and the previous rolling build - 20221218.1 was 200a90a (#79215).
cc @BrzVlad @vargaz

Author: radical
Assignees: -
Labels:

arch-wasm, blocking-clean-ci, area-Codegen-Interpreter-mono, test-failure
Milestone: 8.0.0

@radical radical mentioned this issue Jan 4, 2023
Merged
@runfoapp runfoapp bot mentioned this issue Jan 4, 2023
Closed
@lewing
Copy link
Member

lewing commented Jan 4, 2023

looks like #79943

@lewing
Copy link
Member

lewing commented Jan 4, 2023

cc @SamMonoRT

@BrzVlad
Copy link
Member

BrzVlad commented Jan 4, 2023 •
edited
Loading

#80186 fixes a regression from the same commit reported in the microbenchmarks.

Are all tests still enabled so we can see if that PR is also a fix for this ?

@radical
Copy link
Member Author

radical commented Jan 4, 2023

We run only System.Runtime.Tests+AOT on PRs by default. Use /azp run runtime-wasm-libtests to run all the library tests with AOT.

@BrzVlad
Copy link
Member

BrzVlad commented Jan 4, 2023

This failure was fully deterministic ?

@radical
Copy link
Member Author

radical commented Jan 4, 2023

We have been hitting it on every rolling build, AFAICS.

@radical radical mentioned this issue Jan 4, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 4, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 4, 2023
@radical radical removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jan 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BrzVlad BrzVlad

Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono test-failure
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[mono][interp] Fix issue with clearing of unused defs BrzVlad/runtime
3 participants
@radical @lewing @BrzVlad