Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review usage of nullable suppressions (especially !) in CodeExporter.cs #78704

Open
ViktorHofer opened this issue Nov 22, 2022 · 2 comments
Open

Comments

@ViktorHofer
Copy link
Member

#78703 adds a couple of nullable suppressions that should be removed and cleaned-up. Those suppressions are necessary as previously, the assembly compiled against ref/System.CodeDom but with the above PR now binds against src/System.CodeDom which has a different nullability setting.

@ViktorHofer ViktorHofer added this to the 8.0.0 milestone Nov 22, 2022
@ghost
Copy link

ghost commented Nov 22, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

#78703 adds a couple of nullable suppressions that should be removed and cleaned-up. Those suppressions are necessary as previously, the assembly compiled against ref/System.CodeDom but with the above PR now binds against src/System.CodeDom which has a different nullability setting.

Author: ViktorHofer
Assignees: -
Labels:

area-Meta

Milestone: 8.0.0

@halgab
Copy link
Contributor

halgab commented Aug 5, 2023

Winforms repo has problems as well with the current state of nullability annotations in System.CodeDom. We bumped into the same problems with CodeFieldReferenceExpression, CodePrimitiveExpression and CodePropertyReferenceExpression. See dotnet/winforms#9663

@HongGit HongGit modified the milestones: 8.0.0, 9.0.0 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants