-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_Leipzig #78515
Comments
@stephentoub we are guessing this regression was caused by one of these: Also related regression: dotnet/perf-autofiling-issues#9847 |
Is there actually a regression here? Seems like it briefly dipped for a few days but then went back to exactly where it was before? |
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsRun Information
Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_Leipzig
Reprogit clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Industry_Leipzig*' Related IssuesRegressionsImprovements
PayloadsHistogramEdge Detector InfoSystem.Text.RegularExpressions.Tests.Perf_Regex_Industry_Leipzig.Count(Pattern: "\p{Sm}", Options: NonBacktracking)
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository
|
Looking at the drop, there were some changes to the Regex section (f1a093f). I am not sure if the changes should have resulted in an improvement. It looks like most of the regressions in the related regression issue did the same down then up to the same position, except for the System.Text.RegularExpressions.Tests.Perf_Regex_Industry_RustLang_Sherlock regression which ended up higher than the previous line. Generally, I am unfamiliar with this area so will take what someone with more knowledge thinks. |
Thanks, @LoopedBard3. I took a deeper look, and I think the remaining tiny regressions from #78003 are acceptable fallout from fixing the other issues. |
Run Information
Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_Leipzig
Test Report
Repro
Related Issues
Regressions
Improvements
Payloads
Baseline
Compare
Histogram
Edge Detector Info
Collection Data
System.Text.RegularExpressions.Tests.Perf_Regex_Industry_Leipzig.Count(Pattern: "\p{Sm}", Options: NonBacktracking)
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: