Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Unify implementation of Weak References in all runtimes. #75587

Closed
VSadov opened this issue Sep 14, 2022 · 2 comments
Closed

[NativeAOT] Unify implementation of Weak References in all runtimes. #75587

VSadov opened this issue Sep 14, 2022 · 2 comments
Milestone

Comments

@VSadov
Copy link
Member

VSadov commented Sep 14, 2022

This mostly covers unification with CoreCLR.
Unification with Mono is nearly done in #76173

A followup to #75436
Since we employ eager finalization, some simplifications are possible. Managed implementation in NativeAOT would be an example.

Ideally CoreClr switches to a managed implementation like in NativeAOT, which seems a lot simpler as it does not need to deal with concerns such as protecting the referenced object and the weak reference instance itself.
The problematic part could be the COM/WINRT/IWeakReference support. Perhaps it can be done via FCall callouts.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 14, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@janvorli janvorli added this to the 8.0.0 milestone Sep 14, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Sep 14, 2022
@VSadov VSadov changed the title Consider cleaning up implementation of weak references. [NativeAOT] Unify implementation of Weak References in all runtimes. Sep 28, 2022
@VSadov
Copy link
Member Author

VSadov commented Nov 9, 2022

Completed in #77196

@VSadov VSadov closed this as completed Nov 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants