-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The browser-wasm SDK should automatically reference the threading/perf-tracing ref assemblies #72872
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsSome property property that uses the And the same thing for the
|
it is #72412 but yes that is blocked on wbt at the moment |
The ref assemblies should be same for all the 3 variants, correct? |
we have extra ref assemblies ( I tried this out and it seemed to work (compilation would use the ref assemblies from the nugets, not the ones in the base SDK) if we're doing different runtime packs, I'm not sure if it's possible to place ref assemblies into the runtime packs directly. that might be simpler. |
So, we need 3 ref pack nugets then? |
We also need a few Wasm.Build.Tests to exercise using the threaded runtimes, and the extra ref assemblies. |
No? we need the SDK to add a PackageReference to one of the two new nugets when the corresponding runtime variant is selected that just has the handful of updated ref assemblies. |
|
This is now mostly done (see https://github.com/lambdageek/hithread) I think the only remaining thing is to automatically add a |
done |
Some property property that uses the
multithreaded
runtime pack for the runtime artifacts and that adds a<PackageReference Include="Microsoft.NET.WebAssembly.Threading" IncludeAssets="compile" PrivateAssets="none" />
package to use the right ref assemblies.And the same thing for the
perftrace
runtime pack and theSystem.Diagnostics.Tracing.WebAssembly.PerfTracing
ref assembliesThe text was updated successfully, but these errors were encountered: