-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system.net.quic.functional.tests failing with stack buffer overflow #72429
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThese tests are failing with HRESULT 0xC0000409, which is STATUS_STACK_BUFFER_OVERRUN. Runfo Tracking Issue: system.net.quic.functional.tests failing with stack overrun
Build Result Summary
|
@dotnet/ncl This is failing a lot, please look at it ASAP |
What stack overflow, I randomly opened few console logs and I'm getting: I also downloaded one of the dumps and that fails with:
Microsoft.VisualStudio.TestPlatform.ObjectModel which doesn't seem related to S.N.Quic. So I'm confused. Where did you see the stack overflow @agocke ? EDIT: Also, all the platforms in the table above do not support msquic, so none of the tests are running due to this check:
|
In my PR #72376 I had failures in net7.0-windows-Release-x64-CoreCLR_checked-Windows.10.Amd64.Open with the error code above (0xC0000409 or -1073740791). C:\h\w\A02708DC\w\A4610901\e>"C:\h\w\A02708DC\p\dotnet.exe" exec --runtimeconfig System.Net.Quic.Functional.Tests.runtimeconfig.json --depsfile System.Net.Quic.Functional.Tests.deps.json xunit.console.dll System.Net.Quic.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
----- end Mon 07/18/2022 17:08:48.24 ----- exit code -1073740791 ---------------------------------------------------------- |
Triage: Looks like an accidental regression caused by yesterday's merged PR. We will revert ASAP - @CarnaViire kindly offered help. |
JFYI the PR in question is #72262 |
I tried to execute the tests on Win 10 VM and I did not manage to reproduce the crash. I used downloaded binaries produced from the CI. One thing that is very weird is that conditional test filtering does not seem to work. (All tests should have been skipped/disabled)
Any ideas how to reproduce the crash? |
If you look at some of the console logs from the table above, you'll see:
So it wasn't attempting to run the tests. Where does your "dotent.exe" comes from? If you look at
|
From the Helix payload, downloaded using the |
I see, I was missing the deps parameter |
These tests are failing with HRESULT 0xC0000409, which is STATUS_STACK_BUFFER_OVERRUN.
Runfo Tracking Issue: system.net.quic.functional.tests failing with stack overrun
Build Result Summary
The text was updated successfully, but these errors were encountered: