Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2x RPS improvement in Json-https benchmark. why? #71060

Closed
EgorBo opened this issue Jun 21, 2022 · 4 comments
Closed

2x RPS improvement in Json-https benchmark. why? #71060

EgorBo opened this issue Jun 21, 2022 · 4 comments
Labels
tenet-performance Performance related issue

Comments

@EgorBo
Copy link
Member

EgorBo commented Jun 21, 2022

It'd be nice to identify why we're seeing a stable 2x RPS (very uncommon to see) improvement in this benchmark (https://aka.ms/aspnet/benchmarks, 2nd page) but only on AMD machine 😮

image

commit range in dotnet/runtime: a78211b...4adb117
commit range in dotnet/aspnetcore: dotnet/aspnetcore@ab3e5e2...10b1fd9

cc @sebastienros

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 21, 2022
@EgorBo
Copy link
Member Author

EgorBo commented Jun 21, 2022

I wonder if it could be dotnet/aspnetcore#41790 (slow vpblendvb?) cc @meziantou

@EgorBo EgorBo added the tenet-performance Performance related issue label Jun 21, 2022
@EgorBo
Copy link
Member Author

EgorBo commented Jun 21, 2022

ah, looks like dotnet/aspnetcore#42237 so dotnet/runtime is probably the wrong repo for it
cc @halter73

@sebastienros
Copy link
Member

Yes, this should be it, since this is removing the bottlenecks on high cores. Visible on AMD because it's the machine with the most used cores. So far we capped the Ampere machines to 28 cores for this reason. I will configure a different ARM profile using 80 cores. We'll see the differences compared to 6.0 in the KPIs.

@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jun 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tenet-performance Performance related issue
Projects
None yet
Development

No branches or pull requests

2 participants