Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Regressions in System.Text.Json.Tests.Perf_Base64 #68821

Closed
performanceautofiler bot opened this issue May 3, 2022 · 6 comments
Closed

[Perf] Regressions in System.Text.Json.Tests.Perf_Base64 #68821

performanceautofiler bot opened this issue May 3, 2022 · 6 comments
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented May 3, 2022

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline d3189a2caadb7463f2f41ae320bd02fea40269e7
Compare ffe71b9a4a929b4f8b24624d0f2f586bc4b2350f
Diff Diff

Regressions in System.Text.Json.Tests.Perf_Base64

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
WriteByteArrayAsBase64_NoEscaping - Duration of single invocation 63.71 ns 82.46 ns 1.29 0.12 False
WriteByteArrayAsBase64_HeavyEscaping - Duration of single invocation 64.13 ns 80.17 ns 1.25 0.15 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Tests.Perf_Base64*'

Payloads

Baseline
Compare

Histogram

System.Text.Json.Tests.Perf_Base64.WriteByteArrayAsBase64_NoEscaping(NumberOfBytes: 100)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 82.4631353405496 > 66.8014902886472.
IsChangePoint: Marked as a change because one of 3/30/2022 6:37:35 PM, 4/25/2022 3:15:54 PM, 5/3/2022 11:42:39 AM falls between 4/24/2022 10:52:31 PM and 5/3/2022 11:42:39 AM.
IsRegressionStdDev: Marked as regression because -10.667357133180618 (T) = (0 -76.1482995503608) / Math.Sqrt((18.656527350552018 / (21)) + (3.3567302567720687 / (40))) is less than -2.000995378087428 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (40) - 2, .025) and -0.16027386490559686 = (65.62959130046116 - 76.1482995503608) / 65.62959130046116 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Tests.Perf_Base64.WriteByteArrayAsBase64_HeavyEscaping(NumberOfBytes: 100)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 80.16879039836958 > 66.80239971672258.
IsChangePoint: Marked as a change because one of 3/30/2022 6:37:35 PM, 4/25/2022 5:27:54 PM, 5/3/2022 11:42:39 AM falls between 4/24/2022 10:52:31 PM and 5/3/2022 11:42:39 AM.
IsRegressionStdDev: Marked as regression because -12.354209897329405 (T) = (0 -75.97372135681076) / Math.Sqrt((15.407291616174499 / (22)) + (2.637913393969536 / (39))) is less than -2.000995378087428 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (22) + (39) - 2, .025) and -0.16618473300296027 = (65.14724400582416 - 75.97372135681076) / 65.14724400582416 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added CoreClr untriaged New issue has not been triaged by the area owner labels May 3, 2022
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues May 3, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@DrewScoggins DrewScoggins changed the title [Perf] Changes at 4/25/2022 5:27:54 PM [Perf] Regressions in System.Text.Json.Tests.Perf_Base64 May 3, 2022
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels May 3, 2022
@DrewScoggins
Copy link
Member

Might be related to #68447

@danmoseley danmoseley added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 3, 2022
@ghost
Copy link

ghost commented May 3, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS Windows 10.0.19042
Baseline d3189a2caadb7463f2f41ae320bd02fea40269e7
Compare ffe71b9a4a929b4f8b24624d0f2f586bc4b2350f
Diff Diff

Regressions in System.Text.Json.Tests.Perf_Base64

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
WriteByteArrayAsBase64_NoEscaping - Duration of single invocation 63.71 ns 82.46 ns 1.29 0.12 False
WriteByteArrayAsBase64_HeavyEscaping - Duration of single invocation 64.13 ns 80.17 ns 1.25 0.15 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Tests.Perf_Base64*'

Payloads

Baseline
Compare

Histogram

System.Text.Json.Tests.Perf_Base64.WriteByteArrayAsBase64_NoEscaping(NumberOfBytes: 100)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 82.4631353405496 > 66.8014902886472.
IsChangePoint: Marked as a change because one of 3/30/2022 6:37:35 PM, 4/25/2022 3:15:54 PM, 5/3/2022 11:42:39 AM falls between 4/24/2022 10:52:31 PM and 5/3/2022 11:42:39 AM.
IsRegressionStdDev: Marked as regression because -10.667357133180618 (T) = (0 -76.1482995503608) / Math.Sqrt((18.656527350552018 / (21)) + (3.3567302567720687 / (40))) is less than -2.000995378087428 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (21) + (40) - 2, .025) and -0.16027386490559686 = (65.62959130046116 - 76.1482995503608) / 65.62959130046116 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Text.Json.Tests.Perf_Base64.WriteByteArrayAsBase64_HeavyEscaping(NumberOfBytes: 100)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 80.16879039836958 > 66.80239971672258.
IsChangePoint: Marked as a change because one of 3/30/2022 6:37:35 PM, 4/25/2022 5:27:54 PM, 5/3/2022 11:42:39 AM falls between 4/24/2022 10:52:31 PM and 5/3/2022 11:42:39 AM.
IsRegressionStdDev: Marked as regression because -12.354209897329405 (T) = (0 -75.97372135681076) / Math.Sqrt((15.407291616174499 / (22)) + (2.637913393969536 / (39))) is less than -2.000995378087428 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (22) + (39) - 2, .025) and -0.16618473300296027 = (65.14724400582416 - 75.97372135681076) / 65.14724400582416 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: DrewScoggins
Labels:

tenet-performance, tenet-performance-benchmarks, area-CodeGen-coreclr, untriaged, refs/heads/main, RunKind=micro, Windows 10.0.19042, Regression, CoreClr, x64

Milestone: -

@danmoseley
Copy link
Member

I think so too -- there are no JSON changes here.

@JulieLeeMSFT
Copy link
Member

cc @SingleAccretion.

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label May 5, 2022
@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone May 5, 2022
@SingleAccretion
Copy link
Contributor

I was not able to reproduce the time differences locally when reverting #68447, so I believe both regressions represent re-baselining of modal behavior:

image

image

@SingleAccretion SingleAccretion removed their assignment May 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2022
@jeffhandley jeffhandley added runtime-coreclr specific to the CoreCLR runtime and removed CoreClr labels Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

5 participants