System.Diagnostics.Perf_Process.GetProcessById has regressed 50% on Windows

[adamsitnik]

System.Diagnostics.Perf_Process.GetProcessById has regressed 50% on Windows

Reporting System:

Looking at the commit diff it's most likely caused by #64723 (cc @epeshk)

Repro:

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_monthly.py net7.0-preview2 net7.0-preview3 --filter System.Diagnostics.Perf_Process.GetProcessById

System.Diagnostics.Perf_Process.GetProcessById

Result	Ratio	Operating System	Bit
Slower	0.48	Windows 10	X64
Slower	0.50	Windows 11	X64
Slower	0.49	Windows 11	X64
Slower	0.44	Windows 11	X64
Same	1.02	alpine 3.13	X64
Same	1.02	centos 7	X64
Same	0.97	debian 11	X64
Same	0.96	pop 20.04	X64
Same	1.00	ubuntu 18.04	X64
Faster	1.15	ubuntu 18.04	X64
Same	0.96	alpine 3.12	Arm64
Faster	1.18	debian 11	Arm64
Same	1.01	ubuntu 18.04	Arm64
Slower	0.47	Windows 10	Arm64
Slower	0.42	Windows 11	Arm64
Slower	0.43	Windows 10	X86
Slower	0.48	Windows 11	X86
Slower	0.49	Windows 11	X86
Slower	0.34	Windows 7 SP1	X86
Same	1.07	ubuntu 18.04	Arm
Slower	0.44	Windows 10	Arm
Same	1.02	macOS Monterey 12.2.1	X64
Same	1.05	macOS Monterey 12.3.1	X64

[ghost]

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process
See info in area-owners.md if you want to be subscribed.

Issue Details

---

System.Diagnostics.Perf_Process.GetProcessById has regressed 50% on Windows

Reporting System:

Looking at the commit diff it's most likely caused by #64723 (cc @epeshk)

Repro:

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_monthly.py net7.0-preview2 net7.0-preview3 --filter System.Diagnostics.Perf_Process.GetProcessById

System.Diagnostics.Perf_Process.GetProcessById

Result	Ratio	Operating System	Bit
Slower	0.48	Windows 10	X64
Slower	0.50	Windows 11	X64
Slower	0.49	Windows 11	X64
Slower	0.44	Windows 11	X64
Same	1.02	alpine 3.13	X64
Same	1.02	centos 7	X64
Same	0.97	debian 11	X64
Same	0.96	pop 20.04	X64
Same	1.00	ubuntu 18.04	X64
Faster	1.15	ubuntu 18.04	X64
Same	0.96	alpine 3.12	Arm64
Faster	1.18	debian 11	Arm64
Same	1.01	ubuntu 18.04	Arm64
Slower	0.47	Windows 10	Arm64
Slower	0.42	Windows 11	Arm64
Slower	0.43	Windows 10	X86
Slower	0.48	Windows 11	X86
Slower	0.49	Windows 11	X86
Slower	0.34	Windows 7 SP1	X86
Same	1.07	ubuntu 18.04	Arm
Slower	0.44	Windows 10	Arm
Same	1.02	macOS Monterey 12.2.1	X64
Same	1.05	macOS Monterey 12.3.1	X64

Author:	adamsitnik
Assignees:	-
Labels:	area-System.Diagnostics.Process, os-windows
Milestone:	-

[stephentoub]

I believe this is expected. The previous code was simply wrong, and doing the right thing is more expensive.

[danmoseley]

Right, the new call to GetExitCodeProcess is necessary.