Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate what metrics need to be added to the runtime #63649

Closed
Tracked by #62027
tarekgh opened this issue Jan 11, 2022 · 2 comments
Closed
Tracked by #62027

Investigate what metrics need to be added to the runtime #63649

tarekgh opened this issue Jan 11, 2022 · 2 comments
Assignees
Labels
area-System.Diagnostics.Metric enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@tarekgh
Copy link
Member

tarekgh commented Jan 11, 2022

This issue is to track the investigation of which areas in the runtime need to add metrics instrumentation. The investigation will include looking at all areas using EventCounters to add metrics support there too.
and/or adapted to use the newer Metrics API in addition to

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jan 11, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@tarekgh tarekgh added area-System.Diagnostics.Metric and removed untriaged New issue has not been triaged by the area owner labels Jan 11, 2022
@tarekgh tarekgh added this to the 7.0.0 milestone Jan 11, 2022
@tarekgh tarekgh added the enhancement Product code improvement that does NOT require public API changes/additions label Jan 11, 2022
@tarekgh tarekgh assigned tarekgh and noahfalk and unassigned tarekgh Jan 13, 2022
@noahfalk
Copy link
Member

I did some investigation and the direction we are looking at so far is to add metrics via OpenTelemetry instrumentation libraries that ship out of band from the runtime. We'll get into more specifics on the exact metrics in design docs and issues in the OpenTelemetry dotnet repo.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Diagnostics.Metric enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

2 participants