-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Check if python
is installed when installing the workload
#54638
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsRight now the build expects python to be in the path on linux but ends up checking this by running
|
Likely the cause of #54342 |
|
python
is installed when installing the workload
This needs to be done on the sdk side, so closing this in favor of - dotnet/sdk#26050 . |
Doing it in WorkloadManifest.targets would mean that we do it for every build. Though maybe we can add some sentinel file in |
I was thinking something simple like |
That we essentially do: runtime/src/mono/wasm/build/WasmApp.Native.targets Lines 474 to 486 in e43e315
First we run This will show
So, if we are not adding a check at workload install time, then I think there is nothing else to be done here. But please re-open if you don't agree. |
Right now the build expects python to be in the path on linux but ends up checking this by running
emcc --version
and not surfacing the error text.The text was updated successfully, but these errors were encountered: