[Perf] Regressions in Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable

[DrewScoggins]

Run Information

Architecture	arm64
OS	Windows 10.0.19041
Baseline	5f15498d937653986821d636c04cd03c58d4bb4c
Compare	293d47286161827ecc0d6e96f9eb7b82dafe8307
Diff	Diff

Regressions in Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable

Benchmark	Baseline	Test	Test/Base	Test Quality	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
Scoped - Duration of single invocation	84.69 ns	107.57 ns	1.27	0.34
Transient - Duration of single invocation	160.48 ns	7.33 μs	45.66	0.41

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable*'

Payloads

Baseline
Compare

Histogram

Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable.Scoped

Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable.Transient

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

[ghost]

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run Information

Architecture	arm64
OS	Windows 10.0.19041
Baseline	5f15498d937653986821d636c04cd03c58d4bb4c
Compare	293d47286161827ecc0d6e96f9eb7b82dafe8307
Diff	Diff

Regressions in Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable

Benchmark	Baseline	Test	Test/Base	Test Quality	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
Scoped - Duration of single invocation	84.69 ns	107.57 ns	1.27	0.34
Transient - Duration of single invocation	160.48 ns	7.33 μs	45.66	0.41

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable*'

Payloads

Baseline
Compare

Histogram

Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable.Scoped

Microsoft.Extensions.DependencyInjection.GetServiceIEnumerable.Transient

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author:	DrewScoggins
Assignees:	-
Labels:	arch-arm64, arch-x64, area-Extensions-DependencyInjection, os-linux, os-windows, tenet-performance, tenet-performance-benchmarks, untriaged
Milestone:	-

[DrewScoggins]

#52140

[eerhardt]

@davidfowl @pakrym

[maryamariyan]

here are the latest charts:

[davidfowl]

So only enumerables regressed?

[pakrym]

Did my change prevent IEnumerable accessors from being compiled? The jump is very high for transient.

[davidfowl]

We need to look into it, last time we regressed the perf it was throwing exceptions and nobody knew 😄

[pakrym]

Yeah, I think it might be IL building process failing. we need to add a debug.Fail somewhere :)

[pakrym]

We do have it in https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/DynamicServiceProviderEngine.cs#L42

[davidfowl]

@pakrym spot the bug

runtime/src/libraries/Microsoft.Extensions.DependencyInjection/src/ServiceProvider.cs

Line 170 in 7c8f5fb

_realizedServices[callSite.ImplementationType] = accessor;

[eerhardt]

@maryamariyan is working on getting perf numbers with this fixed. My hope is it fixes these regressions.

[pakrym]

Oh no, 🤦 ImplementationType..

[maryamariyan]

@maryamariyan is working on getting perf numbers with this fixed. My hope is it fixes these regressions.

yes, more info available in this comment #56781 (comment)

[eerhardt]

Fixed by #57155.